Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: ignore file attributes #520

Merged
merged 1 commit into from Oct 14, 2022
Merged

windows: ignore file attributes #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions backend_windows.go
View file
Open in desktop
Expand Up @@ -294,7 +294,6 @@ func (w *Watcher) WatchList() []string {
// This should all be removed at some point, and just use windows.FILE_NOTIFY_*
const (
sysFSALLEVENTS = 0xfff
sysFSATTRIB = 0x4
sysFSCREATE = 0x100
sysFSDELETE = 0x200
sysFSDELETESELF = 0x400
Expand All @@ -320,9 +319,6 @@ func (w *Watcher) newEvent(name string, mask uint32) Event {
if mask&sysFSMOVE == sysFSMOVE || mask&sysFSMOVESELF == sysFSMOVESELF || mask&sysFSMOVEDFROM == sysFSMOVEDFROM {
e.Op |= Rename
}
if mask&sysFSATTRIB == sysFSATTRIB {
e.Op |= Chmod
}
return e
}

Expand Down Expand Up @@ -735,9 +731,6 @@ func (w *Watcher) toWindowsFlags(mask uint64) uint32 {
if mask&sysFSMODIFY != 0 {
m |= windows.FILE_NOTIFY_CHANGE_LAST_WRITE
}
if mask&sysFSATTRIB != 0 {
m |= windows.FILE_NOTIFY_CHANGE_ATTRIBUTES
}
if mask&(sysFSMOVE|sysFSCREATE|sysFSDELETE) != 0 {
m |= windows.FILE_NOTIFY_CHANGE_FILE_NAME | windows.FILE_NOTIFY_CHANGE_DIR_NAME
}
Expand Down
15 changes: 15 additions & 0 deletions backend_windows_test.go
View file
Open in desktop
Expand Up @@ -50,3 +50,18 @@ func TestRemoveState(t *testing.T) {
}
check(0)
}

func TestWindowsNoAttributeChanges(t *testing.T) {
tmp := t.TempDir()
file := filepath.Join(tmp, "TestFsnotifyEventsExisting.testfile")

touch(t, file) // Create a file before watching directory
w := newCollector(t, tmp)
w.collect(t)
chmod(t, 0o400, file) // Make the file read-only, which is an attribute change

have := w.stop(t)
if len(have) != 0 {
t.Fatalf("should not have received any events, received:\n%s", have)
}
}
12 changes: 0 additions & 12 deletions fsnotify_test.go
View file
Open in desktop
Expand Up @@ -252,20 +252,12 @@ func TestWatchCreate(t *testing.T) {
symlink(t, filepath.Join(tmp, "file"), tmp, "link")
}, `
create /link

windows:
create /link
write /link
`},
{"create new symlink to directory", func(t *testing.T, w *Watcher, tmp string) {
addWatch(t, w, tmp)
symlink(t, tmp, tmp, "link")
}, `
create /link

windows:
create /link
write /link
`},

// FIFO
Expand Down Expand Up @@ -548,10 +540,6 @@ func TestWatchSymlink(t *testing.T) {
}, `
create /link

windows:
create /link
write /link

# No events at all on Dragonfly
# TODO: should fix this.
dragonfly:
Expand Down