Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: ignore file attributes #520

Merged
merged 1 commit into from Oct 14, 2022
Merged

windows: ignore file attributes #520

merged 1 commit into from Oct 14, 2022

Commits on Oct 13, 2022

  1. windows: ignore file attributes

    On Windows a FILE_ACTION_MODIFIED event (i.e. a Write event) is
    triggered on file attribute changes, rather than some dedicates
    ATTRIBUTE_CHANGED event. Looking at the docs, I don't really see a way
    to distinguish between "real" write events and attribute changes. This is
    very odd, but seems to be how the ReadDirectoryChangesW() API works.
    
    The only way I can see to distinguish between the two events is to set
    up two filters: one with a FILE_NOTIFY_CHANGE_ATTRIBUTES, and one
    without. But that seems overly complex, and no one asked to get Chmod
    events for Windows; it's not really all that interesting on Windows
    anyway.
    
    The problem is that some software (anti-virus, backup software, etc.)
    can issue lots of attribute changes, causing a lot of "fake" Write
    events.
    
    So remove the FILE_NOTIFY_CHANGE_ATTRIBUTES and sysFSATTRIB flags.
    
    This was adapted from the tilt-dev/fsnotify fork:
    tilt-dev#8
    
    Fixes #487
    arp242 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    231b436 View commit details
    Browse the repository at this point in the history