Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify GenericDictionaryEquivalencyStep #2191

Merged
merged 4 commits into from
Apr 30, 2023
Merged

Simplify GenericDictionaryEquivalencyStep #2191

merged 4 commits into from
Apr 30, 2023

Commits on Apr 30, 2023

  1. Remove always true check 

    `comparands.Expectation` is null-checked at the first thing in `Handle`
    @jnyrup
    jnyrup committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    94e8cf8 View commit details
    Browse the repository at this point in the history

  2. Make a single generic call 

    We would currently either call into AssertSameLengthMethod or AssertDictionaryEquivalenceMethod
This saves us a static field
    @jnyrup
    jnyrup committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    fced243 View commit details
    Browse the repository at this point in the history

  3. Use patterns over TryGet

    @jnyrup
    jnyrup committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    d3f5a18 View commit details
    Browse the repository at this point in the history

  4. Inline Handle

    @jnyrup
    jnyrup committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    b6f0d8c View commit details
    Browse the repository at this point in the history