Simplify GenericDictionaryEquivalencyStep
#2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
commented
Apr 21, 2023
Src/FluentAssertions/Equivalency/Steps/GenericDictionaryEquivalencyStep.cs
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 4842772664Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
jnyrup
force-pushed
the
dictionary_equivalency_cleanup
branch
from
2a15bb7
to
aaa1c55
Compare
|
The decreased coverage is due to deleted lines. no change in missed lines/branches. |
dennisdoomen
approved these changes
Apr 29, 2023
Src/FluentAssertions/Equivalency/Steps/GenericDictionaryEquivalencyStep.cs
Outdated
Show resolved
Hide resolved
Src/FluentAssertions/Equivalency/Steps/GenericDictionaryEquivalencyStep.cs
Outdated
Show resolved
Hide resolved
| @@ -37,10 +37,8 @@ private DictionaryInterfaceInfo(Type key, Type value) | |||
| /// <remarks>> | |||
| /// The <paramref name="role"/> is used to describe the <paramref name="target"/> in failure messages. | |||
| /// </remarks> | |||
| public static bool TryGetFrom(Type target, string role, out DictionaryInterfaceInfo result) | |||
| public static DictionaryInterfaceInfo FindFrom(Type target, string role) | |||
There was a problem hiding this comment.
🤔 I actually prefer the original TryGetFrom, but don't hold that preference strongly.
`comparands.Expectation` is null-checked at the first thing in `Handle`
We would currently either call into AssertSameLengthMethod or AssertDictionaryEquivalenceMethod This saves us a static field
jnyrup
force-pushed
the
dictionary_equivalency_cleanup
branch
from
aaa1c55
to
b6f0d8c
Compare
mergify bot
pushed a commit
to Testably/Testably.Abstractions
that referenced
this pull request
Aug 23, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [FluentAssertions](https://www.fluentassertions.com/) ([source](https://togithub.com/fluentassertions/fluentassertions)) | nuget | minor | `6.11.0` -> `6.12.0` | --- ### Release Notes <details> <summary>fluentassertions/fluentassertions (FluentAssertions)</summary> ### [`v6.12.0`](https://togithub.com/fluentassertions/fluentassertions/releases/tag/6.12.0) [Compare Source](https://togithub.com/fluentassertions/fluentassertions/compare/6.11.0...6.12.0) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### New features - Added `Be`, `NotBe` and `BeOneOf` for object comparisons with custom comparer by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2243 - Extend `AssemblyAssertions` with `HavePublicKey` and `BeUnsigned` by [@​Corniel](https://togithub.com/Corniel) in [fluentassertions/fluentassertions#2207 - Add `NotContainItemsAssignableTo` by [@​Leo506](https://togithub.com/Leo506) in [fluentassertions/fluentassertions#2266 ##### Improvements - Format records and anonymous types with their member values by [@​benagain](https://togithub.com/benagain) in [fluentassertions/fluentassertions#2144 - Improve caller identification for Visual Basic by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2254 ##### Fixes - Avoid quoting newlines by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2202 - Include because+becauseArgs when comparing collections of enums for equivalency by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2214 - Fix auto conversion to enums by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2261 ##### Documentation - Github -> GitHub by [@​danielchalmers](https://togithub.com/danielchalmers) in [fluentassertions/fluentassertions#2190 - Fix badge links by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2193 - Fix example wording by [@​cskwrd](https://togithub.com/cskwrd) in [fluentassertions/fluentassertions#2206 - Improve documentation on `ExcludingNestedObjects` by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2211 - Add missing `HaveElement()` occurrence docs by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2217 - Add documentation for `IComparer<T>` overload by [@​ITaluone](https://togithub.com/ITaluone) in [fluentassertions/fluentassertions#2220 - Update docs about thread safety by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2238 ##### Others - CA1860: Avoid using 'Enumerable.Any()' extension method by [@​Evangelink](https://togithub.com/Evangelink) in [fluentassertions/fluentassertions#2196 - Update PR template by [@​eNeRGy164](https://togithub.com/eNeRGy164) in [fluentassertions/fluentassertions#2188 - Code coverage improvements by [@​sdelarosbil](https://togithub.com/sdelarosbil) in [fluentassertions/fluentassertions#2180 - Remove sponsor Semantic Merge from the website by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2194 - Upmerge master to develop by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2195 - Simplify `GenericDictionaryEquivalencyStep` by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2191 - Cleanup by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2201 - Bump all dependencies by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2198 - Add Qodana by [@​matkoch](https://togithub.com/matkoch) in [fluentassertions/fluentassertions#2204 - Bump nuget dependencies by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2227 - Prepare for .NET8 analyzers by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2228 - Qodana fixes by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2229 - Update Nugets by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2240 - Analyzer cleanups by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2250 - Group framework dependent configuration by [@​Corniel](https://togithub.com/Corniel) in [fluentassertions/fluentassertions#2247 - Update cspell by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2255 - Update ruby gems by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2257 - Another Qodana test from the same repository by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2258 - Qodana fixes by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2221 - Add a pre-check if a user can help with a PR by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2262 - Fix qodana issues part 2 by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2264 - Release 6.12 by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2270 #### New Contributors - [@​benagain](https://togithub.com/benagain) made their first contribution in [fluentassertions/fluentassertions#2144 - [@​cskwrd](https://togithub.com/cskwrd) made their first contribution in [fluentassertions/fluentassertions#2206 - [@​Corniel](https://togithub.com/Corniel) made their first contribution in [fluentassertions/fluentassertions#2247 - [@​Leo506](https://togithub.com/Leo506) made their first contribution in [fluentassertions/fluentassertions#2266 **Full Changelog**: fluentassertions/fluentassertions@6.11.0...6.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
mergify bot
pushed a commit
to Testably/Testably.Architecture.Rules
that referenced
this pull request
Aug 23, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [FluentAssertions](https://www.fluentassertions.com/) ([source](https://togithub.com/fluentassertions/fluentassertions)) | nuget | minor | `6.11.0` -> `6.12.0` | --- ### Release Notes <details> <summary>fluentassertions/fluentassertions (FluentAssertions)</summary> ### [`v6.12.0`](https://togithub.com/fluentassertions/fluentassertions/releases/tag/6.12.0) [Compare Source](https://togithub.com/fluentassertions/fluentassertions/compare/6.11.0...6.12.0) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### New features - Added `Be`, `NotBe` and `BeOneOf` for object comparisons with custom comparer by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2243 - Extend `AssemblyAssertions` with `HavePublicKey` and `BeUnsigned` by [@​Corniel](https://togithub.com/Corniel) in [fluentassertions/fluentassertions#2207 - Add `NotContainItemsAssignableTo` by [@​Leo506](https://togithub.com/Leo506) in [fluentassertions/fluentassertions#2266 ##### Improvements - Format records and anonymous types with their member values by [@​benagain](https://togithub.com/benagain) in [fluentassertions/fluentassertions#2144 - Improve caller identification for Visual Basic by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2254 ##### Fixes - Avoid quoting newlines by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2202 - Include because+becauseArgs when comparing collections of enums for equivalency by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2214 - Fix auto conversion to enums by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2261 ##### Documentation - Github -> GitHub by [@​danielchalmers](https://togithub.com/danielchalmers) in [fluentassertions/fluentassertions#2190 - Fix badge links by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2193 - Fix example wording by [@​cskwrd](https://togithub.com/cskwrd) in [fluentassertions/fluentassertions#2206 - Improve documentation on `ExcludingNestedObjects` by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2211 - Add missing `HaveElement()` occurrence docs by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2217 - Add documentation for `IComparer<T>` overload by [@​ITaluone](https://togithub.com/ITaluone) in [fluentassertions/fluentassertions#2220 - Update docs about thread safety by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2238 ##### Others - CA1860: Avoid using 'Enumerable.Any()' extension method by [@​Evangelink](https://togithub.com/Evangelink) in [fluentassertions/fluentassertions#2196 - Update PR template by [@​eNeRGy164](https://togithub.com/eNeRGy164) in [fluentassertions/fluentassertions#2188 - Code coverage improvements by [@​sdelarosbil](https://togithub.com/sdelarosbil) in [fluentassertions/fluentassertions#2180 - Remove sponsor Semantic Merge from the website by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2194 - Upmerge master to develop by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2195 - Simplify `GenericDictionaryEquivalencyStep` by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2191 - Cleanup by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2201 - Bump all dependencies by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2198 - Add Qodana by [@​matkoch](https://togithub.com/matkoch) in [fluentassertions/fluentassertions#2204 - Bump nuget dependencies by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2227 - Prepare for .NET8 analyzers by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2228 - Qodana fixes by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2229 - Update Nugets by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2240 - Analyzer cleanups by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2250 - Group framework dependent configuration by [@​Corniel](https://togithub.com/Corniel) in [fluentassertions/fluentassertions#2247 - Update cspell by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2255 - Update ruby gems by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2257 - Another Qodana test from the same repository by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2258 - Qodana fixes by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2221 - Add a pre-check if a user can help with a PR by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2262 - Fix qodana issues part 2 by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2264 - Release 6.12 by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2270 #### New Contributors - [@​benagain](https://togithub.com/benagain) made their first contribution in [fluentassertions/fluentassertions#2144 - [@​cskwrd](https://togithub.com/cskwrd) made their first contribution in [fluentassertions/fluentassertions#2206 - [@​Corniel](https://togithub.com/Corniel) made their first contribution in [fluentassertions/fluentassertions#2247 - [@​Leo506](https://togithub.com/Leo506) made their first contribution in [fluentassertions/fluentassertions#2266 **Full Changelog**: fluentassertions/fluentassertions@6.11.0...6.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Architecture.Rules). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mergify bot
pushed a commit
to Testably/Testably.Abstractions.FluentAssertions
that referenced
this pull request
Aug 23, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [FluentAssertions](https://www.fluentassertions.com/) ([source](https://togithub.com/fluentassertions/fluentassertions)) | nuget | minor | `6.11.0` -> `6.12.0` | --- ### Release Notes <details> <summary>fluentassertions/fluentassertions (FluentAssertions)</summary> ### [`v6.12.0`](https://togithub.com/fluentassertions/fluentassertions/releases/tag/6.12.0) [Compare Source](https://togithub.com/fluentassertions/fluentassertions/compare/6.11.0...6.12.0) <!-- Release notes generated using configuration in .github/release.yml at master --> ##### What's Changed ##### New features - Added `Be`, `NotBe` and `BeOneOf` for object comparisons with custom comparer by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2243 - Extend `AssemblyAssertions` with `HavePublicKey` and `BeUnsigned` by [@​Corniel](https://togithub.com/Corniel) in [fluentassertions/fluentassertions#2207 - Add `NotContainItemsAssignableTo` by [@​Leo506](https://togithub.com/Leo506) in [fluentassertions/fluentassertions#2266 ##### Improvements - Format records and anonymous types with their member values by [@​benagain](https://togithub.com/benagain) in [fluentassertions/fluentassertions#2144 - Improve caller identification for Visual Basic by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2254 ##### Fixes - Avoid quoting newlines by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2202 - Include because+becauseArgs when comparing collections of enums for equivalency by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2214 - Fix auto conversion to enums by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2261 ##### Documentation - Github -> GitHub by [@​danielchalmers](https://togithub.com/danielchalmers) in [fluentassertions/fluentassertions#2190 - Fix badge links by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2193 - Fix example wording by [@​cskwrd](https://togithub.com/cskwrd) in [fluentassertions/fluentassertions#2206 - Improve documentation on `ExcludingNestedObjects` by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2211 - Add missing `HaveElement()` occurrence docs by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2217 - Add documentation for `IComparer<T>` overload by [@​ITaluone](https://togithub.com/ITaluone) in [fluentassertions/fluentassertions#2220 - Update docs about thread safety by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2238 ##### Others - CA1860: Avoid using 'Enumerable.Any()' extension method by [@​Evangelink](https://togithub.com/Evangelink) in [fluentassertions/fluentassertions#2196 - Update PR template by [@​eNeRGy164](https://togithub.com/eNeRGy164) in [fluentassertions/fluentassertions#2188 - Code coverage improvements by [@​sdelarosbil](https://togithub.com/sdelarosbil) in [fluentassertions/fluentassertions#2180 - Remove sponsor Semantic Merge from the website by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2194 - Upmerge master to develop by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2195 - Simplify `GenericDictionaryEquivalencyStep` by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2191 - Cleanup by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2201 - Bump all dependencies by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2198 - Add Qodana by [@​matkoch](https://togithub.com/matkoch) in [fluentassertions/fluentassertions#2204 - Bump nuget dependencies by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2227 - Prepare for .NET8 analyzers by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2228 - Qodana fixes by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2229 - Update Nugets by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2240 - Analyzer cleanups by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2250 - Group framework dependent configuration by [@​Corniel](https://togithub.com/Corniel) in [fluentassertions/fluentassertions#2247 - Update cspell by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2255 - Update ruby gems by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2257 - Another Qodana test from the same repository by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2258 - Qodana fixes by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2221 - Add a pre-check if a user can help with a PR by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2262 - Fix qodana issues part 2 by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2264 - Release 6.12 by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2270 ##### New Contributors - [@​benagain](https://togithub.com/benagain) made their first contribution in [fluentassertions/fluentassertions#2144 - [@​cskwrd](https://togithub.com/cskwrd) made their first contribution in [fluentassertions/fluentassertions#2206 - [@​Corniel](https://togithub.com/Corniel) made their first contribution in [fluentassertions/fluentassertions#2247 - [@​Leo506](https://togithub.com/Leo506) made their first contribution in [fluentassertions/fluentassertions#2266 **Full Changelog**: fluentassertions/fluentassertions@6.11.0...6.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions.FluentAssertions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to cythral/brighid-commands
that referenced
this pull request
Aug 23, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [FluentAssertions](https://www.fluentassertions.com/) ([source](https://togithub.com/fluentassertions/fluentassertions)) | nuget | minor | `6.11.0` -> `6.12.0` | --- ### Release Notes <details> <summary>fluentassertions/fluentassertions (FluentAssertions)</summary> ### [`v6.12.0`](https://togithub.com/fluentassertions/fluentassertions/releases/tag/6.12.0) [Compare Source](https://togithub.com/fluentassertions/fluentassertions/compare/6.11.0...6.12.0) <!-- Release notes generated using configuration in .github/release.yml at master --> ##### What's Changed ##### New features - Added `Be`, `NotBe` and `BeOneOf` for object comparisons with custom comparer by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2243 - Extend `AssemblyAssertions` with `HavePublicKey` and `BeUnsigned` by [@​Corniel](https://togithub.com/Corniel) in [fluentassertions/fluentassertions#2207 - Add `NotContainItemsAssignableTo` by [@​Leo506](https://togithub.com/Leo506) in [fluentassertions/fluentassertions#2266 ##### Improvements - Format records and anonymous types with their member values by [@​benagain](https://togithub.com/benagain) in [fluentassertions/fluentassertions#2144 - Improve caller identification for Visual Basic by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2254 ##### Fixes - Avoid quoting newlines by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2202 - Include because+becauseArgs when comparing collections of enums for equivalency by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2214 - Fix auto conversion to enums by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2261 ##### Documentation - Github -> GitHub by [@​danielchalmers](https://togithub.com/danielchalmers) in [fluentassertions/fluentassertions#2190 - Fix badge links by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2193 - Fix example wording by [@​cskwrd](https://togithub.com/cskwrd) in [fluentassertions/fluentassertions#2206 - Improve documentation on `ExcludingNestedObjects` by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2211 - Add missing `HaveElement()` occurrence docs by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2217 - Add documentation for `IComparer<T>` overload by [@​ITaluone](https://togithub.com/ITaluone) in [fluentassertions/fluentassertions#2220 - Update docs about thread safety by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2238 ##### Others - CA1860: Avoid using 'Enumerable.Any()' extension method by [@​Evangelink](https://togithub.com/Evangelink) in [fluentassertions/fluentassertions#2196 - Update PR template by [@​eNeRGy164](https://togithub.com/eNeRGy164) in [fluentassertions/fluentassertions#2188 - Code coverage improvements by [@​sdelarosbil](https://togithub.com/sdelarosbil) in [fluentassertions/fluentassertions#2180 - Remove sponsor Semantic Merge from the website by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2194 - Upmerge master to develop by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2195 - Simplify `GenericDictionaryEquivalencyStep` by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2191 - Cleanup by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2201 - Bump all dependencies by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2198 - Add Qodana by [@​matkoch](https://togithub.com/matkoch) in [fluentassertions/fluentassertions#2204 - Bump nuget dependencies by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2227 - Prepare for .NET8 analyzers by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2228 - Qodana fixes by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2229 - Update Nugets by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2240 - Analyzer cleanups by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2250 - Group framework dependent configuration by [@​Corniel](https://togithub.com/Corniel) in [fluentassertions/fluentassertions#2247 - Update cspell by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2255 - Update ruby gems by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2257 - Another Qodana test from the same repository by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2258 - Qodana fixes by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2221 - Add a pre-check if a user can help with a PR by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2262 - Fix qodana issues part 2 by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2264 - Release 6.12 by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2270 ##### New Contributors - [@​benagain](https://togithub.com/benagain) made their first contribution in [fluentassertions/fluentassertions#2144 - [@​cskwrd](https://togithub.com/cskwrd) made their first contribution in [fluentassertions/fluentassertions#2206 - [@​Corniel](https://togithub.com/Corniel) made their first contribution in [fluentassertions/fluentassertions#2247 - [@​Leo506](https://togithub.com/Leo506) made their first contribution in [fluentassertions/fluentassertions#2266 **Full Changelog**: fluentassertions/fluentassertions@6.11.0...6.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cythral/brighid-commands). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ThorstenSauter
pushed a commit
to ThorstenSauter/NoPlan
that referenced
this pull request
Aug 24, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [FluentAssertions](https://www.fluentassertions.com/) ([source](https://togithub.com/fluentassertions/fluentassertions)) | nuget | minor | `6.11.0` -> `6.12.0` | --- ### Release Notes <details> <summary>fluentassertions/fluentassertions (FluentAssertions)</summary> ### [`v6.12.0`](https://togithub.com/fluentassertions/fluentassertions/releases/tag/6.12.0) [Compare Source](https://togithub.com/fluentassertions/fluentassertions/compare/6.11.0...6.12.0) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### New features - Added `Be`, `NotBe` and `BeOneOf` for object comparisons with custom comparer by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2243 - Extend `AssemblyAssertions` with `HavePublicKey` and `BeUnsigned` by [@​Corniel](https://togithub.com/Corniel) in [fluentassertions/fluentassertions#2207 - Add `NotContainItemsAssignableTo` by [@​Leo506](https://togithub.com/Leo506) in [fluentassertions/fluentassertions#2266 ##### Improvements - Format records and anonymous types with their member values by [@​benagain](https://togithub.com/benagain) in [fluentassertions/fluentassertions#2144 - Improve caller identification for Visual Basic by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2254 ##### Fixes - Avoid quoting newlines by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2202 - Include because+becauseArgs when comparing collections of enums for equivalency by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2214 - Fix auto conversion to enums by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2261 ##### Documentation - Github -> GitHub by [@​danielchalmers](https://togithub.com/danielchalmers) in [fluentassertions/fluentassertions#2190 - Fix badge links by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2193 - Fix example wording by [@​cskwrd](https://togithub.com/cskwrd) in [fluentassertions/fluentassertions#2206 - Improve documentation on `ExcludingNestedObjects` by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2211 - Add missing `HaveElement()` occurrence docs by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2217 - Add documentation for `IComparer<T>` overload by [@​ITaluone](https://togithub.com/ITaluone) in [fluentassertions/fluentassertions#2220 - Update docs about thread safety by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2238 ##### Others - CA1860: Avoid using 'Enumerable.Any()' extension method by [@​Evangelink](https://togithub.com/Evangelink) in [fluentassertions/fluentassertions#2196 - Update PR template by [@​eNeRGy164](https://togithub.com/eNeRGy164) in [fluentassertions/fluentassertions#2188 - Code coverage improvements by [@​sdelarosbil](https://togithub.com/sdelarosbil) in [fluentassertions/fluentassertions#2180 - Remove sponsor Semantic Merge from the website by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2194 - Upmerge master to develop by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2195 - Simplify `GenericDictionaryEquivalencyStep` by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2191 - Cleanup by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2201 - Bump all dependencies by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2198 - Add Qodana by [@​matkoch](https://togithub.com/matkoch) in [fluentassertions/fluentassertions#2204 - Bump nuget dependencies by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2227 - Prepare for .NET8 analyzers by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2228 - Qodana fixes by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2229 - Update Nugets by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2240 - Analyzer cleanups by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2250 - Group framework dependent configuration by [@​Corniel](https://togithub.com/Corniel) in [fluentassertions/fluentassertions#2247 - Update cspell by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2255 - Update ruby gems by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2257 - Another Qodana test from the same repository by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2258 - Qodana fixes by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2221 - Add a pre-check if a user can help with a PR by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2262 - Fix qodana issues part 2 by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2264 - Release 6.12 by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2270 #### New Contributors - [@​benagain](https://togithub.com/benagain) made their first contribution in [fluentassertions/fluentassertions#2144 - [@​cskwrd](https://togithub.com/cskwrd) made their first contribution in [fluentassertions/fluentassertions#2206 - [@​Corniel](https://togithub.com/Corniel) made their first contribution in [fluentassertions/fluentassertions#2247 - [@​Leo506](https://togithub.com/Leo506) made their first contribution in [fluentassertions/fluentassertions#2266 **Full Changelog**: fluentassertions/fluentassertions@6.11.0...6.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ThorstenSauter/NoPlan). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to orso-co/Orso.Arpa.Api
that referenced
this pull request
Aug 26, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [FluentAssertions](https://www.fluentassertions.com/) ([source](https://togithub.com/fluentassertions/fluentassertions)) | nuget | minor | `6.11.0` -> `6.12.0` | --- ### Release Notes <details> <summary>fluentassertions/fluentassertions (FluentAssertions)</summary> ### [`v6.12.0`](https://togithub.com/fluentassertions/fluentassertions/releases/tag/6.12.0) [Compare Source](https://togithub.com/fluentassertions/fluentassertions/compare/6.11.0...6.12.0) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### New features - Added `Be`, `NotBe` and `BeOneOf` for object comparisons with custom comparer by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2243 - Extend `AssemblyAssertions` with `HavePublicKey` and `BeUnsigned` by [@​Corniel](https://togithub.com/Corniel) in [fluentassertions/fluentassertions#2207 - Add `NotContainItemsAssignableTo` by [@​Leo506](https://togithub.com/Leo506) in [fluentassertions/fluentassertions#2266 ##### Improvements - Format records and anonymous types with their member values by [@​benagain](https://togithub.com/benagain) in [fluentassertions/fluentassertions#2144 - Improve caller identification for Visual Basic by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2254 ##### Fixes - Avoid quoting newlines by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2202 - Include because+becauseArgs when comparing collections of enums for equivalency by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2214 - Fix auto conversion to enums by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2261 ##### Documentation - Github -> GitHub by [@​danielchalmers](https://togithub.com/danielchalmers) in [fluentassertions/fluentassertions#2190 - Fix badge links by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2193 - Fix example wording by [@​cskwrd](https://togithub.com/cskwrd) in [fluentassertions/fluentassertions#2206 - Improve documentation on `ExcludingNestedObjects` by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2211 - Add missing `HaveElement()` occurrence docs by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2217 - Add documentation for `IComparer<T>` overload by [@​ITaluone](https://togithub.com/ITaluone) in [fluentassertions/fluentassertions#2220 - Update docs about thread safety by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2238 ##### Others - CA1860: Avoid using 'Enumerable.Any()' extension method by [@​Evangelink](https://togithub.com/Evangelink) in [fluentassertions/fluentassertions#2196 - Update PR template by [@​eNeRGy164](https://togithub.com/eNeRGy164) in [fluentassertions/fluentassertions#2188 - Code coverage improvements by [@​sdelarosbil](https://togithub.com/sdelarosbil) in [fluentassertions/fluentassertions#2180 - Remove sponsor Semantic Merge from the website by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2194 - Upmerge master to develop by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2195 - Simplify `GenericDictionaryEquivalencyStep` by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2191 - Cleanup by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2201 - Bump all dependencies by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2198 - Add Qodana by [@​matkoch](https://togithub.com/matkoch) in [fluentassertions/fluentassertions#2204 - Bump nuget dependencies by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2227 - Prepare for .NET8 analyzers by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2228 - Qodana fixes by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2229 - Update Nugets by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2240 - Analyzer cleanups by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2250 - Group framework dependent configuration by [@​Corniel](https://togithub.com/Corniel) in [fluentassertions/fluentassertions#2247 - Update cspell by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2255 - Update ruby gems by [@​jnyrup](https://togithub.com/jnyrup) in [fluentassertions/fluentassertions#2257 - Another Qodana test from the same repository by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2258 - Qodana fixes by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2221 - Add a pre-check if a user can help with a PR by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2262 - Fix qodana issues part 2 by [@​IT-VBFK](https://togithub.com/IT-VBFK) in [fluentassertions/fluentassertions#2264 - Release 6.12 by [@​dennisdoomen](https://togithub.com/dennisdoomen) in [fluentassertions/fluentassertions#2270 #### New Contributors - [@​benagain](https://togithub.com/benagain) made their first contribution in [fluentassertions/fluentassertions#2144 - [@​cskwrd](https://togithub.com/cskwrd) made their first contribution in [fluentassertions/fluentassertions#2206 - [@​Corniel](https://togithub.com/Corniel) made their first contribution in [fluentassertions/fluentassertions#2247 - [@​Leo506](https://togithub.com/Leo506) made their first contribution in [fluentassertions/fluentassertions#2266 **Full Changelog**: fluentassertions/fluentassertions@6.11.0...6.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/orso-co/Orso.Arpa.Api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2180 I spotted that
GenericDictionaryEquivalencyStep.AssertExpectationIsNotNullchecked if expectation was null, but that had already been done as the first thing inEquivalencyResult Handle(Comparands comparands, IEquivalencyValidationContext context, IEquivalencyValidator nestedValidator).This made it always true or from a mutation testing perspective, an unkillable mutation.
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome