Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static: trim slash before opening file #170

Merged
merged 1 commit into from Aug 7, 2023
Merged

Conversation

wuhan005
Copy link
Member

@wuhan005 wuhan005 commented Aug 7, 2023

Describe the pull request

Fix #169

Link to the issue: #169

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

@wuhan005 wuhan005 requested a review from unknwon August 7, 2023 19:18
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #170 (5453956) into main (977c36e) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   89.31%   89.49%   +0.18%     
==========================================
  Files          17       17              
  Lines        1151     1152       +1     
==========================================
+ Hits         1028     1031       +3     
+ Misses         81       80       -1     
+ Partials       42       41       -1     

Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon unknwon merged commit b567fe0 into main Aug 7, 2023
12 checks passed
@unknwon unknwon deleted the wh/static/trim-slash branch August 7, 2023 21:25
@unknwon
Copy link
Member

unknwon commented Aug 7, 2023

https://github.com/flamego/flamego/releases/tag/v1.9.3 has been created for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static: Index option does not take effect when using go embed file system.
2 participants