-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
static: only strip if the file path is not a single slash #171
Conversation
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 89.49% 89.52% +0.02%
==========================================
Files 17 17
Lines 1152 1155 +3
==========================================
+ Hits 1031 1034 +3
Misses 80 80
Partials 41 41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did the test case pass last time? 馃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous test case does not cover this case, so it passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NVM, i confused myself with the test setup.
https://github.com/flamego/flamego/releases/tag/v1.9.4 has been created for this merge. |
Describe the pull request
I apologize for my carelessness. This PR is related to fixing the previous one. #170
When the
Index
file is placed in the root path of the go embed file system, the single slash/
will be trimmed to an empty string. The go embed file system also can not accept it. 馃槀I have fixed it in this PR and added the test case.
Link to the issue: n/a
Checklist