fix(cloud_firestore): Fix crashes on iOS/macOS #11501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the
FLTFirebaseFirestorePlugin.serverTimestampMap
property from an instance ofNSMutableDictionary
toNSCache
.NSCache
is inherently thread-safe whileNSMutableDictionary
is not.Additionally, this property was not initialised in a consistent manner. It is a static property, but was being initialised in an instance
init
function as well as opportunistically in the property getter.The property is now instantiated via a
dispatch_once
block in the getter.All access to the property is now via the getter.
Related Issues
Fix flutter/#10715
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?