Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): Correct static property getter serverTimestampMap #11570

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

paulw11
Copy link
Contributor

@paulw11 paulw11 commented Sep 11, 2023

Description

Correct an error in the definition of serverTimestampMap.
It was not changed from NSMutableDictionary to NSCache as part of #11501

Related Issues

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@paulw11 paulw11 changed the title Correct static property getter serverTimestampMap Fix: Correct static property getter serverTimestampMap Sep 11, 2023
@russellwheatley russellwheatley changed the title Fix: Correct static property getter serverTimestampMap fix(firestore): Correct static property getter serverTimestampMap Sep 11, 2023
@Lyokone Lyokone merged commit 251d15e into firebase:master Sep 18, 2023
20 of 23 checks passed
@firebase firebase locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants