Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloud_firestore): Fix crashes on iOS/macOS #11501

Merged
merged 5 commits into from
Aug 29, 2023
Merged

fix(cloud_firestore): Fix crashes on iOS/macOS #11501

merged 5 commits into from
Aug 29, 2023

Commits on Aug 21, 2023

  1. Replace NSDictionary with NSCache and 

    use dispatch_once to instantiate `serverTimestampMap`
Fix firebase#10715
    @paulw11
    paulw11 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    7a1c6c6 View commit details
    Browse the repository at this point in the history

  2. Fix firebase#10715 

    Use thread-safe `NSCache` instead of `NSMutableDictionary`
Do not bypass getter
Consistently use static property
USe `dispatch_once` to ensure single instantiation of cache.
    @paulw11
    paulw11 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    3ebd1b2 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. fix formatting

    @paulw11
    paulw11 committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    82b30b0 View commit details
    Browse the repository at this point in the history

  2. Use objectForKey with NSCache

    @paulw11
    paulw11 committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    6f5ac87 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Merge remote-tracking branch 'origin' into timestamp_map_fix

    @russellwheatley
    russellwheatley committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3a2ec18 View commit details
    Browse the repository at this point in the history