validate the status of app version to be ready_for_review before submitting the app

[404pilot]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

This PR tries to fix the issue.

When a specific app version is ready to be submitted for review, fastlane executes a series of API requests.

      submission.add_app_store_version_to_review_items(app_store_version_id: version.id)
      submission.submit_for_review # it throws an error

It fails at line because the state of the version is not "READY_FOR_REVIEW". Fastlane sends the API request too fast.

Description

Basically I added a block to wait till its state becomes 'READY_FOR_REVIEW"

Testing Steps

bundle exec fastlane test

[getaaron]

Thanks so much for the PR! It seems like a nice general approach to this frustrating problem. I think it would be good to make 2 small additions before merging:

• we should provide a config to opt out (similar to skip_waiting_for_build_processing)
• we should use BuildWatcher since it has more advanced support for this e.g. timeouts, handling leading zeroes in version numbers, etc.

WDYT?

[404pilot]

@getaaron thanks for the comment.

1. what is the scenario that people want to opt out?
2. Do you think it is appropriate to create another file VersionWatcher and use skip_waiting_for_version_processing? The build is actually done at this point and it is just that Apple needs to verify the submitted version is good

[thoro23]

Great PR! We just ran into this issue and this PR would have saved us some time and nerves.

[bakatsuyuki]

When does this PR merge? I'm waiting.

[getaaron]

@404pilot actually on thinking about it more I don't think we need to provide an opt out.

[staust]

We are facing the same issue. Would like to see this merged.

[Stepoura]

Any update on this? We would like to see this merged :)

[ilkap07]

Any updates on this? We're still having the issue. Would be nice to see this merged

[getaaron]

@404pilot are you able to make the change so it doesn't loop infinitely?

If not, if someone wants to fork this branch and add that in a separate PR I can merge it in.

[404pilot]

@404pilot are you able to make the change so it doesn't loop infinitely?

If not, if someone wants to fork this branch and add that in a separate PR I can merge it in.

I just updated it and added a new test case @getaaron

[hoangcharles0]

@404pilot Thanks for working on this change! I was wondering when will this PR get merged. I have been experiencing this issue for the past year and this would be great to automate submitting for review

[404pilot]

@404pilot Thanks for working on this change! I was wondering when will this PR get merged. I have been experiencing this issue for the past year and this would be great to automate submitting for review

I am still waiting for someone to review the PR. I would suggest using spaceship or apple connect API to release it after the release step from fastlane fails if you want to automate the workflow now

[ilkap07]

Any updates on this PR?

[404pilot]

can one of admins review it please :)

[stonko1994]

Any updates on this? Still an issue

[getaaron]

Thanks very much for the pull request 🥳