validate the status of app version to be ready_for_review before submitting the app

deliver/lib/deliver/submit_for_review.rb

@@ -47,6 +47,19 @@ def create_review_submission(options, app, version, platform)
       end
 
       submission.add_app_store_version_to_review_items(app_store_version_id: version.id)
+
+      loop do
+        version_with_latest_info = Spaceship::ConnectAPI::AppStoreVersion.get(app_store_version_id: version.id)
+
+        if version_with_latest_info.app_store_state == Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::READY_FOR_REVIEW
+          break
+        end
+
+        UI.message("Waiting for the state of the version to become #{Spaceship::ConnectAPI::AppStoreVersion::AppStoreState::READY_FOR_REVIEW}...")
+
+        sleep(15)
+      end
+
       submission.submit_for_review
     end
 

deliver/spec/submit_for_review_spec.rb

@@ -11,6 +11,12 @@
              id: '1',
              version_string: "1.0.0")
     end
+    let(:ready_for_review_version) do
+      double('ready_for_review_version',
+             id: '1',
+             app_store_state: "READY_FOR_REVIEW",
+             version_string: "1.0.0")
+    end
     let(:selected_build) { double('selected_build') }
     let(:idfa_declaration) { double('idfa_declaration') }
 
@@ -118,6 +124,7 @@
           expect(app).not_to receive(:create_review_submission)
 
           expect(submission).to receive(:add_app_store_version_to_review_items).with(app_store_version_id: edit_version.id)
+          expect(Spaceship::ConnectAPI::AppStoreVersion).to receive(:get).and_return(ready_for_review_version)
           expect(submission).to receive(:submit_for_review)
 
           review_submitter.submit!(options)
@@ -170,6 +177,7 @@
           expect(app).to receive(:create_review_submission).and_return(submission)
 
           expect(submission).to receive(:add_app_store_version_to_review_items).with(app_store_version_id: edit_version.id)
+          expect(Spaceship::ConnectAPI::AppStoreVersion).to receive(:get).and_return(ready_for_review_version)
           expect(submission).to receive(:submit_for_review)
 
           review_submitter.submit!(options)
@@ -202,6 +210,7 @@
           expect(app).to receive(:create_review_submission).and_return(submission)
 
           expect(submission).to receive(:add_app_store_version_to_review_items).with(app_store_version_id: edit_version.id)
+          expect(Spaceship::ConnectAPI::AppStoreVersion).to receive(:get).and_return(ready_for_review_version)
           expect(submission).to receive(:submit_for_review)
 
           review_submitter.submit!(options)
@@ -231,6 +240,7 @@
           expect(app).to receive(:create_review_submission).and_return(submission)
 
           expect(submission).to receive(:add_app_store_version_to_review_items).with(app_store_version_id: edit_version.id)
+          expect(Spaceship::ConnectAPI::AppStoreVersion).to receive(:get).and_return(ready_for_review_version)
           expect(submission).to receive(:submit_for_review)
 
           review_submitter.submit!(options)
@@ -259,6 +269,7 @@
           expect(app).to receive(:create_review_submission).and_return(submission)
 
           expect(submission).to receive(:add_app_store_version_to_review_items).with(app_store_version_id: edit_version.id)
+          expect(Spaceship::ConnectAPI::AppStoreVersion).to receive(:get).and_return(ready_for_review_version)
           expect(submission).to receive(:submit_for_review)
 
           review_submitter.submit!(options)
@@ -298,6 +309,7 @@
           expect(app).to receive(:create_review_submission).and_return(submission)
 
           expect(submission).to receive(:add_app_store_version_to_review_items).with(app_store_version_id: edit_version.id)
+          expect(Spaceship::ConnectAPI::AppStoreVersion).to receive(:get).and_return(ready_for_review_version)
           expect(submission).to receive(:submit_for_review)
 
           review_submitter.submit!(options)
@@ -337,6 +349,7 @@
           expect(app).to receive(:create_review_submission).and_return(submission)
 
           expect(submission).to receive(:add_app_store_version_to_review_items).with(app_store_version_id: edit_version.id)
+          expect(Spaceship::ConnectAPI::AppStoreVersion).to receive(:get).and_return(ready_for_review_version)
           expect(submission).to receive(:submit_for_review)
 
           review_submitter.submit!(options)

spaceship/lib/spaceship/connect_api/models/app_store_version.rb

@@ -27,6 +27,7 @@ class AppStoreVersion
 
       module AppStoreState
         READY_FOR_SALE = "READY_FOR_SALE"
+        READY_FOR_REVIEW = "READY_FOR_REVIEW"
         PROCESSING_FOR_APP_STORE = "PROCESSING_FOR_APP_STORE"
         PENDING_DEVELOPER_RELEASE = "PENDING_DEVELOPER_RELEASE"
         PENDING_APPLE_RELEASE = "PENDING_APPLE_RELEASE"