-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm64 simulators & catalyst support (#475) #543
Conversation
Summary: Edits build scripts to allow merging architectures into .xcframework instead of using lipo for building fat framework. Adds compatibility with arm64 iOS Simulators on Apple M1 Macs and allows using Hermes with RN apps built for Mac Catalyst. Fixes facebook#460 and facebook#468 Pull Request resolved: facebook#475 Differential Revision: D29465045 Pulled By: Huxpro fbshipit-source-id: 6291aac9ee47db83d6f78822767019ec0277a899
This pull request was exported from Phabricator. Differential Revision: D29465045 |
This is a rebased version of the original PR that we can use to tell whether or not the CI breakages were false negatives due to outdating issue. |
There are two more things that I would do, before merging this PR, both relatively easy: 1/ Add a new target to our unit tests, that would be Mac Catalyst, and make CI run and test it (similar to what we do for iOS and Mac already) 2/ For the time being, we cannot do the same for Apple Silicon, since it's not supported. Is there someone with Apple M1 to do the proper testing? |
Let's merge this one with a failing CI and @Titozzz will send a follow up PR renaming the destination folder from Context: the build fails when a folder contains both |
I believe we should be closing this one in favor of #546 |
Summary:
Edits build scripts to allow merging architectures into .xcframework instead of using lipo for building fat framework.
Adds compatibility with arm64 iOS Simulators on Apple M1 Macs and allows using Hermes with RN apps built for Mac Catalyst.
Fixes #460 and #468
Pull Request resolved: #475
Differential Revision: D29465045
Pulled By: Huxpro