Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64 simulators & catalyst support (#475) #543

Closed
wants to merge 2 commits into from

Conversation

Huxpro
Copy link
Contributor

@Huxpro Huxpro commented Jun 30, 2021

Summary:
Edits build scripts to allow merging architectures into .xcframework instead of using lipo for building fat framework.
Adds compatibility with arm64 iOS Simulators on Apple M1 Macs and allows using Hermes with RN apps built for Mac Catalyst.

Fixes #460 and #468

Pull Request resolved: #475

Differential Revision: D29465045

Pulled By: Huxpro

Summary:
Edits build scripts to allow merging architectures into .xcframework instead of using lipo for building fat framework.
Adds compatibility with arm64 iOS Simulators on Apple M1 Macs and allows using Hermes with RN apps built for Mac Catalyst.

Fixes facebook#460 and facebook#468

Pull Request resolved: facebook#475

Differential Revision: D29465045

Pulled By: Huxpro

fbshipit-source-id: 6291aac9ee47db83d6f78822767019ec0277a899
@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Jun 30, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D29465045

@Huxpro
Copy link
Contributor Author

Huxpro commented Jun 30, 2021

This is a rebased version of the original PR that we can use to tell whether or not the CI breakages were false negatives due to outdating issue.

utils/build-ios-framework.sh Outdated Show resolved Hide resolved
@grabbou
Copy link
Contributor

grabbou commented Jul 1, 2021

There are two more things that I would do, before merging this PR, both relatively easy:

1/ Add a new target to our unit tests, that would be Mac Catalyst, and make CI run and test it (similar to what we do for iOS and Mac already)

2/ For the time being, we cannot do the same for Apple Silicon, since it's not supported. Is there someone with Apple M1 to do the proper testing?

@grabbou
Copy link
Contributor

grabbou commented Jul 5, 2021

Let's merge this one with a failing CI and @Titozzz will send a follow up PR renaming the destination folder from iphoneos to universal.

Context: the build fails when a folder contains both .framework and .xcframework, which happens right now as we put .xcframework into iphoneos folder that already has a .framework with iPhone slices only.

CocoaPods/CocoaPods#10759

@TheSavior
Copy link
Member

I believe we should be closing this one in favor of #546

@TheSavior TheSavior closed this Jul 8, 2021
facebook-github-bot pushed a commit that referenced this pull request Jul 9, 2021
Summary:
This PR is #475 with adjustments
to folder names. It also fixes caches and CI issues.

Pull Request resolved: #546

Test Plan: CircleCI

Reviewed By: mhorowitz

Differential Revision: D29597379

Pulled By: Huxpro

fbshipit-source-id: f278f9c5503965cb998872993a1ce38cfcdaadcc
@Huxpro Huxpro mentioned this pull request Jul 11, 2021
10 tasks
Huxpro pushed a commit that referenced this pull request Jul 12, 2021
Summary:
This PR is #475 with adjustments
to folder names. It also fixes caches and CI issues.

Pull Request resolved: #546

Test Plan: CircleCI

Reviewed By: mhorowitz

Differential Revision: D29597379

Pulled By: Huxpro

fbshipit-source-id: f278f9c5503965cb998872993a1ce38cfcdaadcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Mac Catalyst
5 participants