Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should be included in v0.8.1 #528

Closed
10 tasks done
Huxpro opened this issue Jun 9, 2021 · 9 comments
Closed
10 tasks done

What should be included in v0.8.1 #528

Huxpro opened this issue Jun 9, 2021 · 9 comments
Labels

Comments

@Huxpro
Copy link
Contributor

Huxpro commented Jun 9, 2021

This issue is to discuss which fixes should be backported to the next patch release 0.8.1

Related RN links:

Checklist

Regression tests and releases logs

Android
  • Flipper

image

  • Intl

image

iOS

image

Release
  • NPM
npm notice === Tarball Details ===
npm notice name:          hermes-engine
npm notice version:       0.8.1
npm notice filename:      hermes-engine-0.8.1.tgz
npm notice package size:  16.0 MB
npm notice unpacked size: 21.1 MB
npm notice shasum:        b6d0d70508ac5add2d198304502fb968cdecb8b2
npm notice integrity:     sha512-as9Iccj/qrqqt[...]R1u1xQSYfBRYw==
npm notice total files:   48
npm notice
+ hermes-engine@0.8.1

npm notice === Tarball Details ===
npm notice name:          hermes-engine-cli
npm notice version:       0.8.1
npm notice filename:      hermes-engine-cli-0.8.1.tgz
npm notice package size:  51.8 MB
npm notice unpacked size: 125.4 MB
npm notice shasum:        db5f6053e888c3d71da1b44c807cdd8b93d86c80
npm notice integrity:     sha512-YZlUjaiTdljau[...]s9FEOTT4CvV/w==
npm notice total files:   27
npm notice
+ hermes-engine-cli@0.8.1
  • Cocoapod
--------------------------------------------------------------------------------
 🎉  Congrats

 🚀  hermes-engine (0.8.1) successfully published
 📅  July 15th, 01:15
 🌎  https://cocoapods.org/pods/hermes-engine
 👍  Tell your friends!
--------------------------------------------------------------------------------
@Huxpro Huxpro added the release label Jun 9, 2021
@Huxpro
Copy link
Contributor Author

Huxpro commented Jun 9, 2021

#475

@janicduplessis

This comment has been minimized.

@neildhar
Copy link
Contributor

neildhar commented Jun 9, 2021

@janicduplessis it was rolled back for an unrelated reason and is now committed again. The full list of commits that need to be picked for the intl fix is:
f61a798
1986e4b
dfef1ab
103f1d3
1b3a0c2
ed1baf1

@neildhar
Copy link
Contributor

4002156 to fix #537

@zuhair-naqvi

This comment has been minimized.

@Huxpro
Copy link
Contributor Author

Huxpro commented Jul 11, 2021

62e5abe
520e010

for #546 (originally #475 and #543).

@Huxpro
Copy link
Contributor Author

Huxpro commented Jul 11, 2021

To mediate #114:
fb8c5a5
4d04ed5

9a001f4 ^.. 6a4b95a

@Huxpro
Copy link
Contributor Author

Huxpro commented Jul 12, 2021

Source visibility stack has dependencies on cec7541^..7324df9

@Huxpro
Copy link
Contributor Author

Huxpro commented Jul 12, 2021

For those who would love to help testing Hermes 0.8.1 before we actually published them to NPM and CocoaPod:

Android

  1. download hermes-engine-v0.8.1.tgz from the Github release and install locally.
react-native git/0.65-stable
$ npm install path/to/hermes-engine-vX.Y.Z.tgz 
  1. Follow the instructions to build rn-tester on iOS. As for the time this is written, you can run the below commands:
# debug
react-native git/0.65-stable
$ ./gradlew packages:rn-tester:android:app:installHermesDebug
$ ./scripts/packager.sh  # starts Metro

# release
react-native git/0.65-stable
$ ./gradlew packages:rn-tester:android:app:installHermesRelease

iOS

  1. crawl an old version of hermes-engine.podspec.json:
react-native git/0.65-stable
$ curl -L -O https://raw.githubusercontent.com/CocoaPods/Specs/master/Specs/5/d/0/hermes-engine/0.7.2/hermes-engine.podspec.json
  1. update its version to 0.8.1 and point the http to the new url:
"source": {
    "http": "https://github.com/facebook/hermes/releases/download/v0.8.1/hermes-runtime-darwin-v0.8.1.tar.gz"
},
  1. point react_native_pods.rb to the local hermes engine podspec json.
     pod 'hermes-engine', :podspec => '#{prefix}/hermes-engine.podspec.json'
  1. Follow the instructions to build rn-tester on iOS. As for the time this is written, you need to run the below command and then open the generated RNTesterPods .xcworkspace in XCode to build it.
react-native/packages/rn-tester
$ USE_HERMES=1 bundle exec pod install  --repo-update

@Huxpro Huxpro closed this as completed Jul 15, 2021
@Huxpro Huxpro unpinned this issue Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants