CI add back macos test #646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I understand versioning of MacOS correctly, MacOS 12 is an LTS version and thus is prefered (expressed as 'latest') for long term stable CI processes. But I haven't had much time these days to investigate deeper. Anyways, I would prefer to stop running the tests on MacOS and Windows. Because PHP has become super independent of the underlying OS except for those well documented cases of direct OS proxying. And I believe, but haven't proven yet, that Exercism doesn't and will not teach or use those. So, thanks for looking into a solution. I'll just leave MacOS deactivated and start a discussion in the forum about that topic. |
|
OK. I didn't see that part with LTS I may have overlooked that part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the failing tests yesterday we were running against
macOS-latest(12.7.3) but for what ever reasonmacOS-13normacOS-14is tagged as latest, but with themacOS-13it works again.I'll rebase my open PR when this is merged.
Technically this shouldn't be needed any more after the
setup-phpas the issue shivammathur/setup-php#823 has been resolved, but I would still opt for updating tomacOS-13instead ofmacOS-12whichmacOS-latestpointed too.If you disagree, this PR can be closed.