Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable testing on MacOS #645

Closed
mk-mxp opened this issue Feb 26, 2024 · 4 comments · Fixed by #655
Closed

Re-enable testing on MacOS #645

mk-mxp opened this issue Feb 26, 2024 · 4 comments · Fixed by #655
Labels
x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:rep/small Small amount of reputation x:size/small Small amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)

Comments

@mk-mxp
Copy link
Contributor

mk-mxp commented Feb 26, 2024 •
edited

Due to an issue out of our control testing on PHP8.1+ with MacOS 12 always fails. Enable it again (I commented it out) when shivammathur/setup-php#823 is fixed.

The issue is fixed, but should we really enable it again? See https://forum.exercism.org/t/php-stop-running-ci-tests-on-macos-and-windows/10025
@tomasnorre
Copy link
Contributor

I have created a PR that works with macOS-13.

#646

@mk-mxp mk-mxp added paused Work paused until further notice x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:size/small Small amount of work x:rep/small Small amount of reputation and removed paused Work paused until further notice labels Feb 28, 2024
@mk-mxp
Copy link
Contributor Author

mk-mxp commented Feb 29, 2024

As discussed on the forum, the testing with MacOS and Windows will go on. Currently looking for the best version of MacOS to tie the workflow to. macos-latest was and is macos-12, but there is macos-13 and macos-14 available, too.

@tomasnorre
Copy link
Contributor

Which one should we aim for? I can create the PR again.

@mk-mxp
Copy link
Contributor Author

mk-mxp commented Mar 3, 2024

@tomasnorre Please use macos-12 for re-making the PR. Thank you!

@tomasnorre tomasnorre mentioned this issue Mar 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:rep/small Small amount of reputation x:size/small Small amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI Add back macOS test tomasnorre/exercism-php
2 participants
@tomasnorre @mk-mxp