Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution Layer Meeting 167 #836

Closed
timbeiko opened this issue Jul 20, 2023 · 22 comments
Closed

Execution Layer Meeting 167 #836

timbeiko opened this issue Jul 20, 2023 · 22 comments

Comments

@timbeiko
Copy link
Collaborator

timbeiko commented Jul 20, 2023

@Amxx
Copy link

Amxx commented Jul 24, 2023

Would it be possible to present / discuss EIP-5806 ?

@lightclient
Copy link
Member

I would like to discuss EIP-7377.

@yperbasis
Copy link
Member

Let's clarify whether the EIP-4788 storage should be deleted or not at the end of the block in case the balance of address 0xb is 0. There was a discussion on Discord about it. Currently the EIP-161 empty rule (Eq 14 in the Yellow Paper) doesn't require the storage to be empty, implying that deleting the precompile storage is correct, but to my mind that's contrary to the intent of EIP-4788.

@holiman
Copy link

holiman commented Jul 31, 2023

implying that deleting the precompile storage is correct, but to my mind that's contrary to the intent of EIP-4788.

Yes, wiping the storage at the end of each block is contrary to the intent :)

I concur that it needs to be fixed. My suggestion is to set the nonce to 1, if it is zero every time we do the other 4788-related state modifications.

And with more words: ethereum/EIPs#7431

@timbeiko
Copy link
Collaborator Author

Added it all, @Amxx @lightclient @yperbasis @holiman 👍

@yperbasis
Copy link
Member

I suggest to omit EIP-6780 from devnet 8. There're a few reasons:

  1. devnet 8 introduces quite a few changes already on top of devnet 7 (EIP-1153, 4788, 5656);
  2. We (erigon) and perhaps geth haven't implemented it yet; and
  3. There're no ethereum/tests for it yet.

@holiman
Copy link

holiman commented Aug 1, 2023 via email

@yperbasis
Copy link
Member

Geth merged support for 6780 two weeks ago: ethereum/go-ethereum#27189

OK, maybe we (erigon) can piggyback on that :)

@shemnon
Copy link
Contributor

shemnon commented Aug 1, 2023

Execution-spec-tests has tests for EIP-5656 and EIP-6780 - https://github.com/ethereum/execution-spec-tests/tree/main/tests/cancun

@holiman
Copy link

holiman commented Aug 1, 2023

@shemnon are those available in statetest-format anywhere? Or not until next release?

@ralexstokes
Copy link
Member

we should call this out along w/ the other 4788 updates

ethereum/EIPs#7445

@jrudolf
Copy link

jrudolf commented Aug 1, 2023

@gballet and myself would like to present/discuss Verkle (EIP-6800)
See also https://verkle.info

@shemnon
Copy link
Contributor

shemnon commented Aug 2, 2023

@holiman I'm not sure what the execution spec tests team is planning. Here's the output from a current snapshot - https://gist.github.com/shemnon/83773562a7e728d07bbacf04e3c54682

I checked the master branch of geth along with Besu at one point with their filler and it passed all the tests. I think nothing has changed in the interim.

@yperbasis
Copy link
Member

There are some Engine API PRs that are targeted for devnet-8 but not merged yet: ethereum/execution-apis#398, ethereum/execution-apis#426, ethereum/execution-apis#451. Let's either merge them or exclude from devnet-8.

@timbeiko
Copy link
Collaborator Author

timbeiko commented Aug 2, 2023

Added @yperbasis 👍

@shemnon
Copy link
Contributor

shemnon commented Aug 2, 2023

Do we need a final call for EIP-6780 clarifications?

  • OP stack depends on the burn feature
  • Arbitrum doesn't depend on the burn
  • zksync doesnt' support selfdestruct (they link at the solidity level)
  • starkware reverts on selfdestruct
  • Polygon zkEVM already went to SENDALL and don't burn.
  • zkScroll has it marked as "INVALID" at the moment and expressly said they will follow mainnet's lead
  • Linea - question in process but as the arithmetize Besu's trie logs I don't anticipate problems

For maximum compatibility it looks like the clarification as written is the way to go. Polygon's zkSync will be an outlier but it appears they do not depend on that for correct functioning, which OP stack does depend on the self-burn.

@timbeiko
Copy link
Collaborator Author

timbeiko commented Aug 2, 2023

@shemnon yes, we can cover it.

Also, re: "OP stack depends on the burn feature", they are fine with 6780 as-is given their use case creates + SELFDESTRUCTS a contract in the same transaction.

@parithosh
Copy link
Member

We'd like to bring up the >2M validator state test results that we performed over the week

@timbeiko
Copy link
Collaborator Author

timbeiko commented Aug 3, 2023

Added @parithosh !

@jrudolf
Copy link

jrudolf commented Aug 3, 2023

Slides for the Verkle presentation

@smartprogrammer93
Copy link

@jrudolf slides added here:
https://github.com/tvanepps/EthereumDiscordGuidebook

@timbeiko
Copy link
Collaborator Author

timbeiko commented Aug 9, 2023

Closed in favor of #845

@timbeiko timbeiko closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants