-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-service/client: Add http header option to BasicHTTPClient #9601
Conversation
Warning Rate Limit Exceeded@sebastianst has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 56 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update enhances the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
7519f92
to
e7c8b76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but one blocker on option pattern.
e7c8b76
to
212498b
Compare
212498b
to
8b4a287
Compare
8b4a287
to
db12150
Compare
Description
Adds an http header option to the
BasicHTTPClient
constructor. If set, this header will be added to all http requests.Tests
Added tests of the optional http header parameter and of the header merging code itself.
Additional context
In a followup, I will add a config parameter to op-node to add an optional http header to its Beacon client. This is helpful in API endpoint authentication scenarios where we cannot use http query parameters for authentication, as these might be forwarded to the Beacon endpoint and cause errors.
Metadata
Part 1 of https://github.com/ethereum-optimism/client-pod/issues/600