Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: Add optional Beacon header flag #9604

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

sebastianst
Copy link
Member

Description

Adds optional Beacon header flag. Useful for authentication with Beacon endpoint.

Tests

Added test of http header parsing.

Additional context

Follow-up to #9601.

Metadata

@sebastianst sebastianst requested a review from a team as a code owner February 20, 2024 19:26
@sebastianst sebastianst requested review from ajsutton and removed request for a team February 20, 2024 19:26
@sebastianst sebastianst force-pushed the seb/http-client-header branch from e7c8b76 to 212498b Compare February 20, 2024 20:00
@sebastianst sebastianst force-pushed the seb/beacon-client-header branch 2 times, most recently from 9023dc2 to 240f11c Compare February 20, 2024 20:12
@sebastianst sebastianst force-pushed the seb/http-client-header branch from 212498b to 8b4a287 Compare February 20, 2024 20:12
@sebastianst sebastianst force-pushed the seb/beacon-client-header branch from 240f11c to 5255e39 Compare February 20, 2024 20:29
@sebastianst sebastianst force-pushed the seb/http-client-header branch from 8b4a287 to db12150 Compare February 20, 2024 20:29
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Base automatically changed from seb/http-client-header to develop February 20, 2024 21:00
@sebastianst sebastianst added this pull request to the merge queue Feb 20, 2024
Merged via the queue into develop with commit 3e070e4 Feb 20, 2024
69 checks passed
@sebastianst sebastianst deleted the seb/beacon-client-header branch February 20, 2024 21:32
refcell pushed a commit that referenced this pull request Feb 21, 2024
* op-service/client: Add http header option to BasicHTTPClient

* op-node: Add optional Beacon header flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants