Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.5] backport fix watch event loss after compaction #17612

Conversation

chaochn47
Copy link
Member

Signed-off-by: Chao Chen <chaochn@amazon.com>
@chaochn47 chaochn47 mentioned this pull request Mar 19, 2024
@jmhbnz jmhbnz mentioned this pull request Mar 19, 2024
2 tasks
@ahrtr
Copy link
Member

ahrtr commented Mar 19, 2024

Thanks for the PR.

I do not see the integration test case, did you intentionally not backporting the integration test?

@chaochn47
Copy link
Member Author

I do not see the integration test case, did you intentionally not backporting the integration test?

@ahrtr

Yeah, go failpoint in the mainline integration test is not supported in release-3.5.

I can create one similar e2e test just like TestLeaseRevoke_IgnoreOldLeader though.

@ahrtr
Copy link
Member

ahrtr commented Mar 19, 2024

Thanks for the clarification. I am OK to leave it as it's for now.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

cc @fuweid @jmhbnz @serathius

@ahrtr ahrtr merged commit 2ee038d into etcd-io:release-3.5 Mar 19, 2024
18 checks passed
@ahrtr
Copy link
Member

ahrtr commented Mar 19, 2024

Please also update the changelog for 3.4 and 3.5, thx

@chaochn47 chaochn47 deleted the release-3.5-backport-fix-watch-event-loss-after-compact branch March 19, 2024 21:49
@chaochn47
Copy link
Member Author

Thanks @ahrtr for releasing v3.4.31!

Is there a ETA for releasing [v3.5.13] including the bug fix so we can count on? @serathius

@jmhbnz jmhbnz mentioned this pull request Mar 21, 2024
3 tasks
@jmhbnz
Copy link
Member

jmhbnz commented Mar 21, 2024

Is there a ETA for releasing [v3.5.13] including the bug fix so we can count on? @serathius

Created planning issue #17633 to start the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants