Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: build etcd image of v3.5.13 #124026

Merged
merged 1 commit into from
Apr 22, 2024
Merged

etcd: build etcd image of v3.5.13 #124026

merged 1 commit into from
Apr 22, 2024

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Mar 22, 2024 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Have two major fix for watch:

full detail: etcd-io/etcd@v3.5.12...v3.5.13

/hold
Waiting for: (etcd v3.5.13 is released and keep issue open to tracing something)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Build etcd image v3.5.13

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 22, 2024
@liangyuanpeng liangyuanpeng mentioned this pull request Mar 22, 2024
Merged
@bart0sh bart0sh added this to Triage in SIG Node CI/Test Board Mar 24, 2024
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 26, 2024
@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Mar 30, 2024 •
edited

Etcd v3.5.13 is released, so it's ready to review and we can unhold after the code freeze of kubernetes .

/sig etcd
PTAL,Thanks.
/assign @ahrtr @serathius

similar PR:

@k8s-ci-robot k8s-ci-robot added the sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. label Mar 30, 2024
@ahrtr
Copy link
Member

ahrtr commented Mar 30, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 80ba9f6856c29e7310b1eae10c73d2ba4021d548

@hakman
Copy link
Member

hakman commented Mar 30, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2024
serathius
serathius reviewed Apr 3, 2024
View reviewed changes
build/dependencies.yaml Outdated Show resolved Hide resolved
@serathius
Copy link
Contributor

@liangyuanpeng Can you fix the tests?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2024
@k8s-ci-robot k8s-ci-robot requested a review from ahrtr April 12, 2024 15:24
@liangyuanpeng
etcd: build etcd image of v3.5.13
925bcb8 
Signed-off-by: Lan Liang <gcslyp@gmail.com>
@pacoxu
Copy link
Member

pacoxu commented Apr 18, 2024

/unhold
/lgtm
/assign @dims

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d4e06706015739fa5aea459b51e18b21701f105b

@serathius
Copy link
Contributor

ping, we need this for consistent reads from cache.

@dims
Copy link
Member

dims commented Apr 22, 2024

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liangyuanpeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit c67ea2f into kubernetes:master Apr 22, 2024
14 checks passed
SIG Node CI/Test Board automation moved this from Archive-it to Done Apr 22, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 22, 2024
@serathius
Copy link
Contributor

@liangyuanpeng Can you promote the image?

@liangyuanpeng liangyuanpeng deleted the etcd_build_3.5.13 branch April 23, 2024 02:11
@liangyuanpeng liangyuanpeng mentioned this pull request Apr 23, 2024
Merged
@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Apr 23, 2024 •
edited

@serathius opened a PR for it kubernetes/k8s.io#6750

This was referenced Apr 23, 2024
Open
Open
Open
@liangyuanpeng liangyuanpeng mentioned this pull request May 10, 2024
Open
liangyuanpeng added a commit to liangyuanpeng/kubernetes that referenced this pull request May 16, 2024
@liangyuanpeng
Merge branch 'release-1.30' into automated-cherry-pick-of-kubernetes#…
3c8ad03 
…124026-kubernetes#124027-upstream-release-1.30
@yankay yankay mentioned this pull request May 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@liggitt liggitt Awaiting requested review from liggitt

@ahrtr ahrtr Awaiting requested review from ahrtr

Assignees

@dims dims

@pacoxu pacoxu

@ahrtr ahrtr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@liangyuanpeng @k8s-ci-robot @leilajal @ahrtr @hakman @calvinxu @serathius @pacoxu @dims