Default email sender is not working

[anatol-sialitski]

#10404

[codecov]

Codecov Report

Attention: Patch coverage is 88.71795% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 84.55%. Comparing base (e40dc34) to head (ea55e3e).
Report is 1 commits behind head on master.

❗ Current head ea55e3e differs from pull request most recent head 339e3ab. Consider uploading reports for the commit 339e3ab to get more accurate results

Files	Patch %	Lines
.../com/enonic/xp/mail/impl/MimeMessageConverter.java	85.41%	8 Missing and 6 partials ⚠️
.../java/com/enonic/xp/mail/impl/MailServiceImpl.java	63.15%	7 Missing ⚠️
...n/java/com/enonic/xp/lib/mail/SendMailHandler.java	95.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #10457      +/-   ##
============================================
- Coverage     84.55%   84.55%   -0.01%     
- Complexity    19626    19646      +20     
============================================
  Files          2608     2610       +2     
  Lines         68141    68264     +123     
  Branches       5443     5447       +4     
============================================
+ Hits          57620    57721     +101     
- Misses         7890     7909      +19     
- Partials       2631     2634       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rymsha]

Attachment must be concrete type

String fileName
ByteSource data
String mimeType
Map<String, String> headers

usually API allows to add attachment one by one, too

[rymsha]

Suggested change

	private String defaultFromEmail;
	private volatile String defaultFromEmail;

Because @Modified is called by another thread