Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default email sender is not working #10404

Closed
alansemenov opened this issue Jan 30, 2024 · 0 comments · Fixed by #10470 or #10472
Closed

Default email sender is not working #10404

alansemenov opened this issue Jan 30, 2024 · 0 comments · Fixed by #10470 or #10472
Assignees
Labels
Milestone

Comments

@alansemenov
Copy link
Member

alansemenov commented Jan 30, 2024

If defaultFromEmail is set in the XP mail configuration, it should be used in outgoing emails when it's not explicitly specified.

Examples (assume that defaultFromEmail is set to noreply@enonic.com):

  1. If an email is sent with Some Name<email@domain.com> as a sender, use that as is.
  2. If an email is sent with email@domain.com as a sender, use that as is.
  3. If an email is sent with Some Name<> as a sender, substitute value from defaultFromEmail so that it's sent from Some Name<noreply@enonic.com>.
  4. If an email is sent with <> as a sender or sender not specified, use value from defaultFromEmail so that it's sent from noreply@enonic.com.

Throw an error if the value from defaultFromEmail is required (like in cases 3 and 4 above) but not configured.

@rymsha rymsha assigned anatol-sialitski and unassigned rymsha Mar 6, 2024
@anatol-sialitski anatol-sialitski linked a pull request Mar 13, 2024 that will close this issue
@rymsha rymsha added this to the 7.14.1 milestone Mar 15, 2024
@anatol-sialitski anatol-sialitski linked a pull request Mar 18, 2024 that will close this issue
@anatol-sialitski anatol-sialitski linked a pull request Mar 19, 2024 that will close this issue
@anatol-sialitski anatol-sialitski linked a pull request Mar 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment