docs: clean up removed systemPreferences methods #39334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
added
target/23-x-y
electron-cation
bot
added
documentation 📓
semver/patch
codebytere
approved these changes
Aug 2, 2023
![electron-docs-reviewer[bot]](https://avatars.githubusercontent.com/in/243740?s=60&v=4){kind=small}
2 tasks
|
No Release Notes |
This was referenced Aug 3, 2023
|
I have automatically backported this PR to "26-x-y", please check out #39347 |
|
I have automatically backported this PR to "25-x-y", please check out #39348 |
trop
bot
removed
the
target/26-x-y
|
I have automatically backported this PR to "23-x-y", please check out #39349 |
trop
bot
removed
the
target/25-x-y
|
I have automatically backported this PR to "24-x-y", please check out #39350 |
trop
bot
added
merged/24-x-y
|
@dsanders11 thanks for fixing this, I don't know how I forgot to cleanup the docs back then :) |
win32ss
pushed a commit
to win32ss/supermium-electron
that referenced
this pull request
Sep 24, 2023
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
These were removed in #26849 but the documentation was never removed. There's also some dead code which wasn't removed, but I'll do a follow-up PR to remove that so this PR can be backported without also backporting the code changes. Doing a deep backport to clean up the types since currently the types think these methods exist, but they will fail at run time.
cc @electron/docs
Checklist
Release Notes
Notes: none