Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated systemPreferences color scheme events #39341

Merged
merged 2 commits into from Aug 14, 2023

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Aug 3, 2023

Description of Change

Needs #39334 to land first.

These events were marked as deprecated in #26848 but were never removed.

Checklist

Release Notes

Notes: The deprecated color scheme changed events in systemPreferences have been removed

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 3, 2023
@dsanders11 dsanders11 added the semver/minor backwards-compatible functionality label Aug 3, 2023
@dsanders11 dsanders11 marked this pull request as ready for review August 3, 2023 12:43
@dsanders11 dsanders11 requested a review from a team as a code owner August 3, 2023 12:43
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere force-pushed the remove-deprecated-color-scheme-events branch from 5f68eb8 to 6cd5202 Compare August 10, 2023 09:51
@codebytere
Copy link
Member

Failure is known from #39260

@codebytere codebytere merged commit d166182 into main Aug 14, 2023
14 of 15 checks passed
@codebytere codebytere deleted the remove-deprecated-color-scheme-events branch August 14, 2023 08:37
@release-clerk
Copy link

release-clerk bot commented Aug 14, 2023

Release Notes Persisted

The deprecated color scheme changed events in systemPreferences have been removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🗑 Complete
Development

Successfully merging this pull request may close these issues.

None yet

4 participants