Fix | Throttling of token requests by calling AcquireTokenSilent #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Integrated/Password flows when the account is already cached. Addresses issue dotnet#1915
David-Engel
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
+ Coverage 70.68% 70.78% +0.10%
==========================================
Files 292 292
Lines 61727 61805 +78
==========================================
+ Hits 43629 43747 +118
+ Misses 18098 18058 -40
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 19 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…es the previously used one
lcheunglci
approved these changes
Mar 1, 2023
DavoudEshtehari
approved these changes
Mar 3, 2023
...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
Show resolved
Hide resolved
DavoudEshtehari
approved these changes
Mar 6, 2023
lcheunglci
added a commit
to lcheunglci/SqlClient
that referenced
this pull request
Mar 23, 2023
…net#1925) * Address throttling of token requests by calling AcquireTokenSilent in Integrated/Password flows when the account is already cached. Addresses issue dotnet#1915 Co-authored-by: Lawrence Cheung <31262254+lcheunglci@users.noreply.github.com> Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Apr 13, 2023
…net#1925) * Address throttling of token requests by calling AcquireTokenSilent in Integrated/Password flows when the account is already cached. Addresses issue dotnet#1915 Co-authored-by: Lawrence Cheung <31262254+lcheunglci@users.noreply.github.com> Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com> # Conflicts: # src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Apr 13, 2023
…net#1925) * Address throttling of token requests by calling AcquireTokenSilent in Integrated/Password flows when the account is already cached. Addresses issue dotnet#1915 Co-authored-by: Lawrence Cheung <31262254+lcheunglci@users.noreply.github.com> Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com> # Conflicts: # src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
JRahnama
pushed a commit
that referenced
this pull request
Apr 17, 2023
DavoudEshtehari
added a commit
to DavoudEshtehari/SqlClient
that referenced
this pull request
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address throttling of token requests by calling AcquireTokenSilent in AAD Integrated/Password flows when the account is already cached.
Addresses issue #1915
For reviewing the changes, hiding whitespace produces a slightly easier to read diff.