Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1.1] Fix | Throttling of token requests by calling AcquireTokenSilent #1966

Conversation

lcheunglci
Copy link
Contributor

Backporting fix to address throttling of token requests by calling AcquireTokenSilent in Integrated/Password flows when the account is already cached which addresses issue #1915 into 5.1-servicing branch and these changes are based on #1925.

…net#1925)

* Address throttling of token requests by calling AcquireTokenSilent in Integrated/Password flows when the account is already cached.

Addresses issue dotnet#1915

Co-authored-by: Lawrence Cheung <31262254+lcheunglci@users.noreply.github.com>
Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com>
@lcheunglci lcheunglci added this to the 5.1.1 milestone Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 30.88% and project coverage change: -0.11 ⚠️

Comparison is base (0156df2) 70.83% compared to head (c8679ec) 70.73%.

Additional details and impacted files
@@                Coverage Diff                @@
##           5.1-servicing    #1966      +/-   ##
=================================================
- Coverage          70.83%   70.73%   -0.11%     
=================================================
  Files                292      292              
  Lines              61732    61760      +28     
=================================================
- Hits               43730    43684      -46     
- Misses             18002    18076      +74     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.01% <30.88%> (-0.29%) ⬇️
netfx 69.30% <30.88%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...SqlClient/ActiveDirectoryAuthenticationProvider.cs 59.57% <30.88%> (-0.33%) ⬇️

... and 37 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lcheunglci lcheunglci merged commit f70b9c6 into dotnet:5.1-servicing Mar 27, 2023
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants