Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifies support for SqlHierarchyId and Spatial for .NET Core #1848

Merged
merged 1 commit into from Feb 1, 2023

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Nov 23, 2022

(on Windows anyway, more platform in the works I have been told)

Using this NuGet package: https://www.nuget.org/packages/Microsoft.SqlServer.Types/160.1000.6

fixes #322

fixes #30

(on Windows anyway, more platform in the works I have been told)

fixes dotnet#322

fixes dotnet#30
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 70.16% // Head: 69.73% // Decreases project coverage by -0.43% ⚠️

Coverage data is based on head (ad30d47) compared to base (03f3053).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1848      +/-   ##
==========================================
- Coverage   70.16%   69.73%   -0.44%     
==========================================
  Files         292      292              
  Lines       61727    61727              
==========================================
- Hits        43311    43043     -268     
- Misses      18416    18684     +268     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 74.16% <ø> (+0.12%) ⬆️
netfx 67.67% <ø> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 26.18% <0.00%> (-22.91%) ⬇️
...ata/SqlClient/SqlConnectionTimeoutErrorInternal.cs 30.35% <0.00%> (-21.43%) ⬇️
...c/Microsoft/Data/SqlClient/SqlConnectionFactory.cs 68.85% <0.00%> (-0.82%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.02% <0.00%> (-0.67%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.63% <0.00%> (-0.59%) ⬇️
...ient/netfx/src/Microsoft/Data/SqlClient/SqlUtil.cs 57.14% <0.00%> (-0.49%) ⬇️
...netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs 83.42% <0.00%> (-0.40%) ⬇️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 70.84% <0.00%> (-0.04%) ⬇️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 73.39% <0.00%> (ø)
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 46.07% <0.00%> (+0.08%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Nov 23, 2022

Looks like Linux tests also passed !?

@lcheunglci
Copy link
Contributor

Thanks @ErikEJ for the PR. We found a bug in our pipeline where some of the tests were skipped, so I'll be re-running the tests again.

@lcheunglci
Copy link
Contributor

/azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants