Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on array access deprecation #11212

Merged
merged 2 commits into from
Feb 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Deprecate array access

Use array access on instances of the following classes is deprecated:
Using array access on instances of the following classes is deprecated:

- `Doctrine\ORM\Mapping\DiscriminatorColumnMapping`
- `Doctrine\ORM\Mapping\EmbedClassMapping`
Expand Down
2 changes: 1 addition & 1 deletion src/Persisters/Entity/BasicEntityPersister.php
Original file line number Diff line number Diff line change
Expand Up @@ -1151,7 +1151,7 @@

if (isset($this->class->fieldMappings[$fieldName])) {
$tableAlias = isset($this->class->fieldMappings[$fieldName]->inherited)
? $this->getSQLTableAlias($this->class->fieldMappings[$fieldName]['inherited'])
? $this->getSQLTableAlias($this->class->fieldMappings[$fieldName]->inherited)

Check warning on line 1154 in src/Persisters/Entity/BasicEntityPersister.php

View check run for this annotation

Codecov / codecov/patch

src/Persisters/Entity/BasicEntityPersister.php#L1154

Added line #L1154 was not covered by tests
: $baseTableAlias;

$columnName = $this->quoteStrategy->getColumnName($fieldName, $this->class, $this->platform);
Expand Down
2 changes: 1 addition & 1 deletion src/Query/SqlWalker.php
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@
$class = $this->getMetadataForDqlAlias($alias);

if (isset($class->associationMappings[$fieldName]->inherited)) {
$class = $this->em->getClassMetadata($class->associationMappings[$fieldName]['inherited']);
$class = $this->em->getClassMetadata($class->associationMappings[$fieldName]->inherited);

Check warning on line 789 in src/Query/SqlWalker.php

View check run for this annotation

Codecov / codecov/patch

src/Query/SqlWalker.php#L789

Added line #L789 was not covered by tests
}

$association = $class->associationMappings[$fieldName];
Expand Down