Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on array access deprecation #11212

Merged
merged 2 commits into from Feb 3, 2024
Merged

Follow up on array access deprecation #11212

merged 2 commits into from Feb 3, 2024

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Feb 3, 2024

No description provided.

@greg0ire greg0ire added this to the 3.1.0 milestone Feb 3, 2024
@greg0ire greg0ire changed the title Fix grammar issue in upgrade guide Follow up on array access deprecation Feb 3, 2024
SenseException
SenseException approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the tests react to the deprecations? 🤔

@greg0ire
Copy link
Member Author

greg0ire commented Feb 3, 2024

It's because tests don't cover these 2 cases that I did not catch them. I had used throw new \Exception instead of deprecations to find places to modify.

@greg0ire greg0ire merged commit 3764ebf into doctrine:3.1.x Feb 3, 2024
64 checks passed
@greg0ire greg0ire deleted the fix-grammar branch February 3, 2024 22:51
@SenseException
Copy link
Member

I had used throw new \Exception instead of deprecations to find places to modify

Sounds familiar. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@mpdude mpdude Awaiting requested review from mpdude

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Documentation Improvement
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@greg0ire @SenseException