added correctly updating public boolean when retrieving notes from server

[maaroen]

This PR belongs to this issue:
#604

[CLAassistant]

All committers have signed the CLA.

[sungwoncho]

Hi @maaroen, thanks for your contribution and apologies for my lack of attention for #604.

I agree that the issue exists, and this fixes the issue. And I would like to suggest that we do not merge this to master because the web interface had been discontinued since v2.0.0 (https://github.com/dnote/dnote/blob/master/CHANGELOG.md#200-2022-05-09) since 2022/May/09. In addition, merging this to master will violate the project tenet of 'Simple' (https://github.com/dnote/dnote/wiki#tenets).

One alternative I thought of was to create a new branch from v0.12.0 version of CLI, which was the last version before the web interface had been removed. Then, we can release this as v0.12.1. In order for that to happen, we might need to tweak the logic for checking new version in https://github.com/dnote/dnote/blob/master/pkg/cli/upgrade/upgrade.go#L104-L108 because the current users of v0.15.0 will erroneously be 'upgraded' to v0.12.1 when v0.12.1 is released. At any rate, adding complexity to the upgrade logic does not seem to align with the project's tenet of favoring simplicity.

How would you feel about forking the current version and using the following command to compile a custom version of Dnote (https://github.com/dnote/dnote/blob/master/CONTRIBUTING.md#build)?

[maaroen]

Hi @sungwoncho,

Thanks for the reply, I did not notice that the web interface has been discontinued. Has it been removed all together also for viewing? And what what the reason for doing so If I may ask? (I personally use it a lot to for example share notes)

I did already compile a custom version of the 0.15 CLI for myself with the proposed changes in this PR. That's also the way how it tested it and was able to confirm it working as expected.

I understand the change doesn't make sense if the web interface has been discontinued, which is actually sad to hear since it was a nice interface for the created notes (a nice extra next to the commandline interface).