Fix #61, 62: very frequent freezing of VM during teardown

This will only mitigate the issue and doesn't fix the root cause. The
action doesn't shutdown the VM anymore. Since the action is run
inside a VM itself, everything will be cleaned up automatically.
Hopefully this will make the issue less likely to occur.

changelog.md

@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 ### Changed
 - Run any SSH commands to the VM in verbose mode when debug mode is enabled
+- Mitigate very frequent freezing of VM during teardown ([#61](https://github.com/cross-platform-actions/action/issues/61), [#72](https://github.com/cross-platform-actions/action/issues/72))
+    With this change the action doesn't shutdown the VM. Since the action is
+    run inside a VM itself, everything will be cleaned up automatically.
 
 ## [0.21.1] - 2023-11-03
 ### Fixed

src/action/action.ts

@@ -119,15 +119,9 @@ export class Action {
       } finally {
         core.startGroup('Tearing down VM')
         await this.syncBack(vm.ipAddress)
-        await vm.stop()
       }
     } finally {
-      try {
-        await vm.terminate()
-        fs.rmSync(this.tempPath, {recursive: true})
-      } finally {
-        core.endGroup()
-      }
+      core.endGroup()
     }
   }
 

src/vm.ts

@@ -69,8 +69,8 @@ export abstract class Vm {
     core.info('Booting VM')
     core.debug(this.command.join(' '))
     this.vmProcess = spawn('sudo', this.command, {
-      detached: false,
-      stdio: ['ignore', 'inherit', 'inherit']
+      detached: true,
+      stdio: ['ignore', 'ignore', 'ignore']
     })
 
     if (this.vmProcess.exitCode) {
@@ -104,20 +104,6 @@ export abstract class Vm {
     )
   }
 
-  async stop(): Promise<void> {
-    core.info('Shuting down VM')
-    await this.shutdown()
-  }
-
-  async terminate(): Promise<number> {
-    core.info('Terminating VM')
-    return await exec.exec(
-      'sudo',
-      ['kill', '-s', 'TERM', this.vmProcess.pid.toString()],
-      {ignoreReturnCode: true}
-    )
-  }
-
   async setupWorkDirectory(
     homeDirectory: string,
     workDirectory: string