Fix 'No such file or directory' error

This occurs when running the end-to-end tests locally.

spec/operating_systems/freebsd/freebsd.spec.ts

@@ -12,10 +12,6 @@ import * as xhyve from '../../../src/xhyve_vm'
 
 describe('FreeBSD OperatingSystem', () => {
   class MockHost extends hostModule.Host {
-    get workDirectory(): string {
-      return '/home/runner/work'
-    }
-
     get vmModule(): typeof xhyve | typeof qemu {
       return qemu
     }

spec/operating_systems/netbsd/netbsd.spec.ts

@@ -11,10 +11,6 @@ import * as netbsdQemuVm from '../../../src/operating_systems/netbsd/qemu_vm'
 
 describe('NetBSD OperatingSystem', () => {
   class Host extends hostModule.Host {
-    get workDirectory(): string {
-      return '/home/runner/work'
-    }
-
     get vmModule(): typeof xhyve | typeof qemu {
       return qemu
     }
@@ -92,10 +88,6 @@ describe('NetBSD OperatingSystem', () => {
 
     describe('when on a macOS host', () => {
       class Host extends hostModule.Host {
-        get workDirectory(): string {
-          return '/Users/runner/work'
-        }
-
         get vmModule(): typeof xhyve | typeof qemu {
           return xhyve
         }

src/action/action.ts

@@ -32,7 +32,6 @@ export class Action {
   private readonly input = new input.Input()
   private readonly resourceDisk: ResourceDisk
   private readonly implementation: Implementation
-  private readonly workDirectory
   private readonly sshDirectory: string
   private readonly privateSshKey: fs.PathLike
   private readonly publicSshKey: fs.PathLike
@@ -56,7 +55,6 @@ export class Action {
       this.operatingSystem.actionImplementationKind
     )
 
-    this.workDirectory = this.host.workDirectory
     this.sshDirectory = path.join(this.getHomeDirectory(), '.ssh')
     this.privateSshKey = path.join(this.tempPath, this.privateSshKeyName)
     this.publicSshKey = `${this.privateSshKey}.pub`
@@ -98,7 +96,7 @@ export class Action {
       hypervisorDirectory,
       firmwareDirectory,
       diskImagePath
-    ].map(p => p.slice(this.workDirectory.length + 1))
+    ].map(p => p.slice(this.homeDirectory.length + 1))
 
     const vm = await vmPromise
 
@@ -107,7 +105,7 @@ export class Action {
       await vm.run()
       this.configSSH(vm.ipAddress)
       await vm.wait(120)
-      await this.operatingSystem.setupWorkDirectory(vm, this.workDirectory)
+      await vm.setupWorkDirectory(this.homeDirectory, this.workDirectory)
       await this.syncFiles(
         vm,
         this.targetDiskName,
@@ -235,16 +233,21 @@ export class Action {
     return core.isDebug() ? 'v' : ''
   }
 
+  private get homeDirectory(): string {
+    const components = this.workDirectory.split(path.sep).slice(0, -2)
+    return path.join('/', ...components)
+  }
+
+  private get workDirectory(): string {
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    return process.env['GITHUB_WORKSPACE']!
+  }
+
   private async syncFiles(
     vm: vmModule.Vm,
     ...excludePaths: string[]
   ): Promise<void> {
     if (!this.shouldSyncFiles) {
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-      await vm.execute(`mkdir -p '${process.env['GITHUB_WORKSPACE']!}'`, {
-        log: false
-      })
-
       return
     }
 
@@ -254,7 +257,7 @@ export class Action {
       `-auzrtopg${this.syncVerboseFlag}`,
       '--exclude', '_actions/cross-platform-actions/action',
       ...flatMap(excludePaths, p => ['--exclude', p]),
-      `${this.workDirectory}/`,
+      `${this.homeDirectory}/`,
       `runner@${vm.ipAddress}:work`
     ])
   }
@@ -267,7 +270,7 @@ export class Action {
     await exec.exec('rsync', [
       `-uzrtopg${this.syncVerboseFlag}`,
       `runner@${ipAddress}:work/`,
-      this.workDirectory
+      this.homeDirectory
     ])
   }
 
@@ -279,11 +282,7 @@ export class Action {
         ? '$SHELL'
         : shell.toString(this.input.shell)
     await vm.execute2(
-      [
-        'sh',
-        '-c',
-        `'cd "${process.env['GITHUB_WORKSPACE']}" && exec "${sh}" -e'`
-      ],
+      ['sh', '-c', `'cd "${this.workDirectory}" && exec "${sh}" -e'`],
       Buffer.from(this.input.run)
     )
   }

src/host.ts

@@ -18,7 +18,6 @@ export abstract class Host {
     }
   }
 
-  abstract get workDirectory(): string
   abstract get vmModule(): typeof xhyve | typeof qemu
   abstract get qemu(): HostQemu
   abstract get hypervisor(): hypervisor.Hypervisor
@@ -37,10 +36,6 @@ export abstract class Host {
 }
 
 class MacOs extends Host {
-  get workDirectory(): string {
-    return '/Users/runner/work'
-  }
-
   get vmModule(): typeof xhyve | typeof qemu {
     return xhyve
   }
@@ -78,10 +73,6 @@ class MacOs extends Host {
 }
 
 class Linux extends Host {
-  get workDirectory(): string {
-    return '/home/runner/work'
-  }
-
   get vmModule(): typeof xhyve | typeof qemu {
     return qemu
   }

src/operating_system.ts

@@ -86,26 +86,6 @@ export abstract class OperatingSystem {
     resourcesDirectory: fs.PathLike
   ): Promise<void>
 
-  async setupWorkDirectory(
-    vm: vmModule.Vm,
-    workDirectory: string
-  ): Promise<void> {
-    const destination = `/home/${vmModule.Vm.user}/work`
-
-    await vm.execute('mkdir -p /home/runner/work')
-
-    if (workDirectory === destination)
-      await vm.execute(`rm -rf '${destination}' && mkdir -p '${workDirectory}'`)
-    else {
-      await vm.execute(
-        `rm -rf '${destination}' && ` +
-          `sudo mkdir -p '${workDirectory}' && ` +
-          `sudo chown '${vmModule.Vm.user}' '${workDirectory}' && ` +
-          `ln -sf '${workDirectory}/' '${destination}'`
-      )
-    }
-  }
-
   protected get uuid(): string {
     return '864ED7F0-7876-4AA7-8511-816FABCFA87F'
   }

src/qemu_vm.ts

@@ -44,9 +44,8 @@ export abstract class Vm extends vm.Vm {
       // '-nographic',
 
       '-boot', 'strict=off',
-      /* eslint-disable @typescript-eslint/no-non-null-assertion */
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       '-bios', this.configuration.firmware!.toString()
-      /* eslint-enable @typescript-eslint/no-non-null-assertion */
     ].concat(this.hardDriverFlags)
   }
 

src/vm.ts

@@ -118,6 +118,20 @@ export abstract class Vm {
     )
   }
 
+  async setupWorkDirectory(
+    homeDirectory: string,
+    workDirectory: string
+  ): Promise<void> {
+    const homeDirectoryLinuxHost = `/home/${Vm.user}/work`
+
+    await this.execute(
+      `rm -rf '${homeDirectoryLinuxHost}' && ` +
+        `sudo mkdir -p '${workDirectory}' && ` +
+        `sudo chown -R '${Vm.user}' '${homeDirectory}' && ` +
+        `ln -sf '${homeDirectory}/' '${homeDirectoryLinuxHost}'`
+    )
+  }
+
   protected async shutdown(): Promise<void> {
     throw Error('Not implemented')
   }