Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ResolvedFileToPublish list during publish #1243

Merged

Conversation

MarcoRossignoli
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli commented Oct 29, 2021

image

During publish skip to copy coverlet files if are inside the ResolvedFileToPublish list.

fix #1045
fix #1226
fix #1106
fix #1131
fix #1258

cc: @daveMueller @Haplois

@MarcoRossignoli MarcoRossignoli added the bug Something isn't working label Oct 29, 2021
@daveMueller
Copy link
Collaborator

Thanks @MarcoRossignoli. I totally see that this fixes the issue. But why doesn't this happen with v1.3. There we already had the target CopyCoverletDataCollectorFiles? Also I don't really get why CopyCoverletDataCollectorFiles is needed at all? I would assume that nuget copies the resolved files by its own. E.g. in coverlet.msbuild.targets we don't have something like this target and the files are copied nevertheless.

@Haplois
Copy link

Haplois commented Nov 4, 2021

I haven't find a chance to look at this yet, I'll do it on this weekend. :)

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented Nov 4, 2021

@daveMueller this scenario should run only when we publish so with dotnet publish and after a user can run test/coverage with dotnet test file.dll in all other cases coverlet is resolved using nuget folder.

But why doesn't this happen with v1.3. There we already had the target CopyCoverletDataCollectorFiles?

didn't check, but looking with binlog should be easy to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment