Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverlet.collector: upgrade from 3.0.2 to 3.1.0 breaks dotnet publish - it ships old version of Newtonsoft.Json (9.0.1) #1258

Closed
ZlobnyiSerg opened this issue Nov 11, 2021 · 4 comments · Fixed by #1243
Labels
Solved The issue is solved and can be closed waiting for customer Waiting for customer action

Comments

@ZlobnyiSerg
Copy link

I have big solution with tests referring to coverlet.collector version 3.1.0 nuget package. Some projects in this solution are referred to Newtonsoft.Json 13.0.1.
When I publish my project with

dotnet publish -o ./app

I'm getting old version of Newtonsoft.Json - 9.0.1 instead of 13.0.1 in published folder, and my application can't start as result.

Everything is ok with 3.0.2, broken after 3.1.0 upgrade.

@petli
Copy link
Collaborator

petli commented Nov 12, 2021

I think this is the same problem that's been fixed by #1243, but it has not yet been released.

@daveMueller
Copy link
Collaborator

Yes seems like it's the same issue. @ZlobnyiSerg you can try to consume the nightly build https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md to see if this fixes your issue.

@MarcoRossignoli MarcoRossignoli added as-designed Expected behaviour waiting for customer Waiting for customer action Solved The issue is solved and can be closed and removed as-designed Expected behaviour labels Nov 15, 2021
@MarcoRossignoli
Copy link
Collaborator

@ZlobnyiSerg were you able to give it a try?

@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Jan 16, 2022

It should be fixed in the next release.
Closing for stale conversation, feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solved The issue is solved and can be closed waiting for customer Waiting for customer action
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants