Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot to get TFM information inside custom datacollector? #3360

Open
daveMueller opened this issue Feb 12, 2022 · 2 comments
Open

Hot to get TFM information inside custom datacollector? #3360

daveMueller opened this issue Feb 12, 2022 · 2 comments
Labels

Comments

@daveMueller
Copy link
Contributor

daveMueller commented Feb 12, 2022

Hi,

is there any information on how to get TFM inside our datacollector? As I have seen this issue here #2592, the information must be available. Is it somehow possible to get this information inside the collector so we can pass it to the filename (coverlet-coverage/coverlet#1276)?

@daveMueller
Copy link
Contributor Author

After going through the vstest code I figured out I can do something like this as a workaround.

string framework = _configurationElement["Framework"]?.InnerText;
string tfm = string.IsNullOrEmpty(framework) ? "" : NuGetFramework.Parse(framework).ToString();

With this approach I would have to add another dependency to our code just to parse back the tfm. Is there any plan on changing the runsettings Framework value to the actual tfm? Or additionally expose the tfm?

@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Feb 14, 2022

Hi @daveMueller,

at the moment we don't have any plan for what I know, I think we can add that deps to coverlet...with this fix coverlet-coverage/coverlet#1243 shouldn't be an issue anymore.

@nohwnd do we have other requests for this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants