Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.7] Windows default path overwrite fix #9440

Conversation

CharityKathure
Copy link

Windows Containers have a default path already configured at bootup. WithDefaultPathEnv overwrites this with a unix path

(cherry picked from commit 7d63690 without any additional changes)

Windows Containers have a default path already configured at bootup. WithDefaultPathEnv overwrites this with a unix path

Signed-off-by: charitykathure <kathurecharity505@gmail.com>
(cherry picked from commit 7d63690)
Signed-off-by: Charity Kathure <ckathure@microsoft.com>
@k8s-ci-robot
Copy link

Hi @CharityKathure. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kiashok
Copy link
Contributor

kiashok commented Nov 30, 2023

@CharityKathure could you please include the release branch you are backporting the commit to in the title? Example:

[release/1.7] Fix windows default path overwrite issue

@CharityKathure CharityKathure changed the title Fix windows default path overwrite issue [release/1.7] Fix windows default path overwrite issue Nov 30, 2023
@kiashok
Copy link
Contributor

kiashok commented Nov 30, 2023

/ok-to-test

@CharityKathure CharityKathure changed the title [release/1.7] Fix windows default path overwrite issue [release/1.7] Windows default path overwrite fix Nov 30, 2023
@dmcgowan dmcgowan merged commit 9c65471 into containerd:release/1.7 Nov 30, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants