Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows default path overwrite issue #9439

Conversation

CharityKathure
Copy link

Backport windows default path overwrite fix to 1.7.9 to fix and close nerdctl issue containerd/nerdctl#2485

Windows Containers have a default path already configured at bootup. WithDefaultPathEnv overwrites this with a unix path

Signed-off-by: charitykathure <kathurecharity505@gmail.com>
@k8s-ci-robot
Copy link

Hi @CharityKathure. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kiashok
Copy link
Contributor

kiashok commented Nov 29, 2023

Hi @CharityKathure , could you refer to https://github.com/containerd/containerd/blob/main/RELEASES.md#backporting for backporting the commit to release/1.7 branch please?

@CharityKathure
Copy link
Author

Thank you @kiashok. I have created a different pr using the backporting guidelines shared.

PR link: #9440

Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants