Allow JWT tokens #316
Closed
Allow JWT tokens #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-codecov
approved these changes
Oct 31, 2023
|
@scott-codecov that one ci test is failing. However, at least I tried to remove all UUID checks. Is that CI job somehow using old CLI or how it works? Can that be skipped or what is the situation? |
|
yeah looks like its loading current 0.4.0 version of CLI and trying tests against that. However, it cannot work because the uuid logic is removed in this PR. |
|
@zetaab I think that failing CI step is OK - it's just trying to tell Codecov about the commit but since this PR is originating from a fork the action does not have access to the codecov-cli/.github/workflows/ci.yml Line 46 in 4676151 I'm not sure why the actual test steps are not running though. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As codecov/codecov-api#177 is merged, the token format can be either JWT or UUID.
This PR is blocked for another PR codecov/codecov-action#1054