-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow JWT tokens #325
Allow JWT tokens #325
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
- Coverage 95.48% 95.44% -0.04%
==========================================
Files 80 80
Lines 2723 2702 -21
==========================================
- Hits 2600 2579 -21
Misses 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0680664
to
68c3f4f
Compare
@scott-codecov @dana-yaish could this be merged as its blocking codecov/codecov-action#1054 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* heads/main: simplify the ternary operator amend branch names to be forked-slug:branch-name we need the pr number for the PR API request to know if the command runs in a fork PR chore: Fix helper text in label analysis (#315) taking decoding slug out of is_fork_pr, cause it doesn't feel right to be there adding tests check if the PR is a fork PR chore: remove smart-open (#326)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to fix the failing tests
|
||
import click | ||
|
||
from codecov_cli.fallbacks import CodecovOption, FallbackFieldEnum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems that the tests are failing because CodecovOption
stopped being imported here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joseph-sentry
Cherry picked from #316 to get a signed commit
Closes #316