Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use queue name for event notification config #5369

Merged

Conversation

mattdeboard
Copy link
Contributor

@mattdeboard mattdeboard commented Mar 25, 2024

What this PR solves / how to test

LDW merge exemption under CR-849815

Fixes MQ-586.

Author has addressed the following

  • Tests
    • Included
  • Changeset (Changeset guidelines)
    • Included
  • Public documentation
    • Not necessary because: Pre-release feature. Docs are planned for next week and will be retro-actively linked here @jonesphillip

@mattdeboard mattdeboard requested a review from a team as a code owner March 25, 2024 16:12
Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: 027a486

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 25, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455288981/npm-package-wrangler-5369

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5369/npm-package-wrangler-5369

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455288981/npm-package-wrangler-5369 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455288981/npm-package-create-cloudflare-5369 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455288981/npm-package-cloudflare-kv-asset-handler-5369
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455288981/npm-package-miniflare-5369
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455288981/npm-package-cloudflare-pages-shared-5369
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8455288981/npm-package-cloudflare-vitest-pool-workers-5369

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.39.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240320.0
workerd 1.20240320.1 1.20240320.1
workerd --version 1.20240320.1 2024-03-20

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.29%. Comparing base (7c701bf) to head (027a486).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5369      +/-   ##
==========================================
+ Coverage   72.18%   72.29%   +0.10%     
==========================================
  Files         322      322              
  Lines       16663    16666       +3     
  Branches     4260     4260              
==========================================
+ Hits        12029    12048      +19     
+ Misses       4634     4618      -16     
Files Coverage Δ
packages/wrangler/src/r2/helpers.ts 91.07% <100.00%> (+0.24%) ⬆️
packages/wrangler/src/r2/index.ts 88.20% <ø> (ø)

... and 8 files with indirect coverage changes

@mattdeboard mattdeboard force-pushed the use-queue-name-for-event-notifs branch 3 times, most recently from 5e43139 to 07a91c1 Compare March 27, 2024 15:30
@mattdeboard
Copy link
Contributor Author

Latest force-push = rebasing on latest main

.changeset/rich-oranges-attack.md Outdated Show resolved Hide resolved
.changeset/rich-oranges-attack.md Outdated Show resolved Hide resolved
@mattdeboard mattdeboard force-pushed the use-queue-name-for-event-notifs branch from d6bdb69 to 027a486 Compare March 27, 2024 16:32
@mattdeboard
Copy link
Contributor Author

mattdeboard commented Mar 27, 2024

Force-push = fixing up the commits from applying suggested changes via github UI

@petebacondarwin petebacondarwin added the ldw-exempt PRs marked with this label can be included in releases during LDW. label Mar 27, 2024
@petebacondarwin petebacondarwin merged commit 7115568 into cloudflare:main Mar 27, 2024
20 checks passed
@mattdeboard mattdeboard deleted the use-queue-name-for-event-notifs branch March 27, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ldw-exempt PRs marked with this label can be included in releases during LDW.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants