Improvements to R2 notification commands #5416
Merged
+29
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ce0ffa The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mattdeboard
force-pushed
the
r2-notifs-api-changes
branch
2 times, most recently
from
fd4043e to
e6b3711
Compare
|
Force-push = rebasing on latest |
mattdeboard
force-pushed
the
r2-notifs-api-changes
branch
from
a204acb to
9992177
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8457458019/npm-package-wrangler-5416You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5416/npm-package-wrangler-5416Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8457458019/npm-package-wrangler-5416 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8457458019/npm-package-create-cloudflare-5416 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8457458019/npm-package-cloudflare-kv-asset-handler-5416npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8457458019/npm-package-miniflare-5416npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8457458019/npm-package-cloudflare-pages-shared-5416npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8457458019/npm-package-cloudflare-vitest-pool-workers-5416Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
petebacondarwin
approved these changes
Mar 27, 2024
petebacondarwin
added
the
ldw-exempt
mattdeboard
force-pushed
the
r2-notifs-api-changes
branch
from
f66dbc3 to
c12881f
Compare
Change `event-notification` subcmd to `notification`
Use `object-{create,delete}`, not `_{delete,create}`
Add changeset
mattdeboard
force-pushed
the
r2-notifs-api-changes
branch
from
c12881f to
1ce0ffa
Compare
|
Force-push = reworded a commit to force a rebuild, to try to get past flakey (afaict) test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5416 +/- ##
==========================================
+ Coverage 72.19% 72.27% +0.07%
==========================================
Files 322 322
Lines 16666 16666
Branches 4260 4260
==========================================
+ Hits 12032 12045 +13
+ Misses 4634 4621 -13
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
LDW merge exemption under CR-850842.
Fixes MQ-597.
Author has addressed the following