New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce new naming convention "InputXpath{Checkname}Xxxx.java" in IT area #14715
Comments
Because #14719 fixes the failing build in master, list in the first post does not have a MethodTypeParameterName. I am on that :) |
…dTypeParameterNameXXX.java in IT area
…odifier in IT area
I am on VisibilityModifier |
…rametername in IT area
@MANISH-K-07, I highly recommend to do fixes by packages or by packs of 20 files. to fnish this update quicker and not making a an epic from it. |
@MANISH-K-07 , please update issue description to reference list of suppression and do udpates based on it. |
I am on RecordTypeParameterName |
…rameterName in IT area
…AsWordInName in IT area
@Lmh-java, we appreciate your help with easy issues, you are always welcome, but I recommend you next month to focus on more complicated issues to increase your chances to be selected to gsoc. Ohm there are more participants, same suggestion for others. |
@romani , like you said, let's not make an epic of this issue. I'll close this with multiple PRs at a time in 2 batches like @rnveach suggested at #14725 (comment) |
ok, lets let only @MANISH-K-07 to work on this issue. |
Follow-up of #6981
Until now, XpathRegressionTest validated the pattern
SuppressionXpathRegressionXxxx.java
for input filenamesAll our existing files are named that way, so we bypass them until this issue is fixed.
The pattern has been updated to
InputXpath{Checkname}Xxxx.java
as part of PR #14713All existing modules have been suppressed from validation.
As part of this issue, one module needs to be picked and all input files need to be renamed. Note that the xpath queries need to be verified in respective
XpathRegression{Checkname}Test
after filename change. Also, the setRENAME_INPUT_XPATH
needs to be updated by removing the updated module to re-enable pattern validation.The list of suppressions can be found at :
checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/internal/XpathRegressionTest.java
Lines 121 to 261 in cd1afd9
Example of update : e70b8b5
The text was updated successfully, but these errors were encountered: