Issue #14715: Enforce new naming convention on RecordTypeParameterName in IT area #14727
Conversation
Lmh-java
force-pushed
the
minghao/xpath-naming-convention-record
branch
from
2f47b39
to
5128c8b
Compare
Lmh-java
changed the title
| @@ -41,7 +41,7 @@ protected String getCheckName() { | |||
| @Test | |||
| public void testOne() throws Exception { | |||
| final File fileToProcess = new File(getNonCompilablePath( | |||
| "SuppressionXpathRegressionRecordTypeParameterName1.java")); | |||
| "InputXpathRecordTypeParameterNameExtend.java")); | |||
There was a problem hiding this comment.
| "InputXpathRecordTypeParameterNameExtend.java")); | |
| "InputXpathRecordTypeParameterNameTypeDeclared.java")); |
There was a problem hiding this comment.
I don't see the point why you would name it like that. Could you explain it a bit? Basically, why would you add "TypeXXXX" to the file name?
There was a problem hiding this comment.
The test is testing the generic var with extends and & synatx.
There was a problem hiding this comment.
Please read about TypeVariables in java.
https://docs.oracle.com/javase%2F7%2Fdocs%2Fapi%2F%2F/java/lang/reflect/TypeVariable.html
Make changes if you feel my suggestions make more sense than suffixes "Extend" and "Default"
There was a problem hiding this comment.
Sorry for the late reply, done
| @@ -67,7 +67,7 @@ public void testOne() throws Exception { | |||
| @Test | |||
| public void testTwo() throws Exception { | |||
| final File fileToProcess = new File(getNonCompilablePath( | |||
| "SuppressionXpathRegressionRecordTypeParameterName2.java")); | |||
| "InputXpathRecordTypeParameterNameDefault.java")); | |||
There was a problem hiding this comment.
| "InputXpathRecordTypeParameterNameDefault.java")); | |
| "InputXpathRecordTypeParameterNameTypeDefault.java")); |
…rameterName in IT area
Lmh-java
force-pushed
the
minghao/xpath-naming-convention-record
branch
from
5128c8b
to
0ba217f
Compare
|
@MANISH-K-07 I assume you are done? |
There was a problem hiding this comment.
Yes @rnveach ,
I think everything looks good here but I'm not in the power to approve so please approve if you agree with the suggestions..
Part of #14715