Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #14715: Enforced new naming convention on visibilitymodifier in IT area #14721

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Issue #14715: Enforced new naming convention on visibilitymodifier in IT area #14721

merged 1 commit into from
Mar 26, 2024

Conversation

MANISH-K-07
Copy link
Contributor

Part of #14715

Enforced new naming convention on visibilitymodifier in IT area

@MANISH-K-07
Copy link
Contributor Author

@romani , please see #6981 (comment)
Is that okay with you or do you want me to close the issue in a few PRs ?

@MANISH-K-07
Copy link
Contributor Author

Failing ci doesn't seem related
https://github.com/checkstyle/checkstyle/actions/runs/8433856776/job/23095802696?pr=14721#step:6:24

@romani
Copy link
Member

romani commented Mar 26, 2024

test (common-2)

restated

romani
romani approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge is ci pass

@MANISH-K-07 MANISH-K-07 requested a review from romani March 26, 2024 13:26
@MANISH-K-07
Copy link
Contributor Author

From #14715 (comment), 20 files would mean approx 5-8 modules. I will keep sending PRs timely

@romani romani merged commit 194a6f7 into checkstyle:master Mar 26, 2024
113 of 114 checks passed
@MANISH-K-07 MANISH-K-07 deleted the renameIT1 branch March 26, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani Awaiting requested review from romani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MANISH-K-07 @romani