Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pinned requests package #7672

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Remove pinned requests package #7672

merged 2 commits into from
Apr 19, 2023

Commits on Apr 19, 2023

  1. Remove pinned requests package 

    We currently pin requests to version 2.27.1. This was last bumped in
May of 2022 in 24808f0. Over time its
version has been incremented a few times.

Currently if you run tox you see an error like this:

> /home/runner/work/consumerfinance.gov/consumerfinance.gov/.tox/unittest/lib/python3.8/site-packages/requests/__init__.py:102: RequestsDependencyWarning: urllib3 (1.26.15) or chardet (5.1.0)/charset_normalizer (2.0.12) doesn't match a supported version!

For example, a recent GHA run:

https://github.com/cfpb/consumerfinance.gov/actions/runs/4737203702/jobs/8409716743

I'm not entirely sure why this started showing up now, but it seems to
have to do with psf/requests#6261.

Removing our requests pin seems to work fine.
    @chosak
    chosak committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    5533346 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into deprecate/pinned-requests

    @chosak
    chosak committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    b4009a2 View commit details
    Browse the repository at this point in the history