Remove pinned requests package #7672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently pin requests to version 2.27.1. This was last bumped in May of 2022 in 24808f0. Over time its version has been incremented a few times. Currently if you run tox you see an error like this: > /home/runner/work/consumerfinance.gov/consumerfinance.gov/.tox/unittest/lib/python3.8/site-packages/requests/__init__.py:102: RequestsDependencyWarning: urllib3 (1.26.15) or chardet (5.1.0)/charset_normalizer (2.0.12) doesn't match a supported version! For example, a recent GHA run: https://github.com/cfpb/consumerfinance.gov/actions/runs/4737203702/jobs/8409716743 I'm not entirely sure why this started showing up now, but it seems to have to do with psf/requests#6261. Removing our requests pin seems to work fine.
willbarton
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently pin requests to version 2.27.1. This was last bumped in May of 2022 in 24808f0. Over time its version has been incremented a few times.
Currently if you run tox you see an error like this:
For example, a recent GHA run:
https://github.com/cfpb/consumerfinance.gov/actions/runs/4737203702/jobs/8409716743
I'm not entirely sure why this started showing up now, but it seems to have to do with psf/requests#6261.
Removing our requests pin seems to work fine.
Checklist