github/labeler: disable sync-labels #38158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaml syntax cleaned too. Fixes: ceph#38107 (comment) Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
epuertat
force-pushed
the
fix-labeler-master
branch
from
9bbe700
to
59702b6
Compare
Merged
3 tasks
tchaikov
reviewed
Nov 18, 2020
| repo-token: "${{ secrets.GITHUB_TOKEN }}" | ||
| - uses: actions/labeler@main | ||
| with: | ||
| sync-labels: '' |
There was a problem hiding this comment.
There was a problem hiding this comment.
@tchaikov after checking that code, my bet is that the defaults from the action.yml are somehow injected in the environment, and that's why the empty string doesn't work:
> !!'false'
true
> !!''
falseThere was a problem hiding this comment.
tchaikov
approved these changes
Nov 18, 2020
neha-ojha
approved these changes
Nov 18, 2020
djgalloway
approved these changes
Nov 18, 2020
|
I created this PR to see if we can get this fixed: actions/labeler#113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yaml syntax cleaned too.
From wesnoth/wesnoth@958c82d
Fixes: #38107 (comment)
Signed-off-by: Ernesto Puerta epuertat@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox