qa/mgr/test_progress: add _get_osd_in_out_events to account for osd marked in/out events

[kamoltat]

Fixes a failing test case regarding osd coming back
after being marked out. The old test case wasn't accounting
for a specific event, therefore this resulted in the failure.
The fix basically accounts for a specific event of osd being
marked in/out.

Fixes: https://tracker.ceph.com/issues/48217

Signed-off-by: Kamoltat ksirivad@redhat.com

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[neha-ojha]

can you please follow https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#fixes-lines to add the "Fixes" line and update the commit title to explain what the fix does

[kamoltat]

@neha-ojha I ran 18 tests on this and it passed successfully. Let me know if I should run more tests: https://pulpito.ceph.com/ksirivad-2020-11-17_04:43:46-rados:mgr-wip-mgr-progress-fix-48217-distro-basic-smithi/

[neha-ojha]

@neha-ojha I ran 18 tests on this and it passed successfully. Let me know if I should run more tests: https://pulpito.ceph.com/ksirivad-2020-11-17_04:43:46-rados:mgr-wip-mgr-progress-fix-48217-distro-basic-smithi/

If there aren't any other tests exercising the progress module, then this is good.

[neha-ojha]

nit: how about changing the title to qa/mgr/test_progress: add _get_osd_in_out_events to account for osd marked in/out events?

[neha-ojha]

@epuertat @tchaikov does the auto labeler remove manually added labels? Seeing it in this PR.

[epuertat]

@epuertat @tchaikov does the auto labeler remove manually added labels? Seeing it in this PR.

@neha-ojha this is the issue: actions/labeler#104

"Hacked" (until the real fix happens) in #38158

[tchaikov]

@kamoltat please use your own repo for creating topic branches. and also please note the title of a pull request is not the title of a commit, in future, i'd suggest use git commit --amend to update your commit and repush to update your change.

[smithfarm]

Just to supplement what @tchaikov said: here we have a descriptive PR title ("qa/mgr/test_progress: add _get_osd_in_out_events to account for osd marked in/out events") coupled with a bad, non-descriptive commit title ("qa/mgr/test_progress: fix bug 48217"), yet it's the commit title that enters the git history. The git history is what gets downloaded to each developer's computer, and the commit title is what is shown in git log. The github PR title, by contrast, only resides on github's servers and can (effectively) only be seen via a web browser.

https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#describe-your-changes has more guidance on this subject.

[kamoltat]

@smithfarm I agree, my apologies for the bad commit title will try to improve for the next PRs/commits