Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route53): multivalue answer routing #28938

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Conversation

badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Jan 31, 2024

Issue

Closes #28939.

Reason for this change

When configuring multi-value answer routing, it was always necessary to set it via the L1 method or use an escape hatch.

Description of changes

I added multiValueAnswering property to RecordSetProps.

    new route53.ARecord(this, 'MultiValueAnswerRouting', {
      zone: hostedZone,
      recordName: 'www',
      target: route53.RecordTarget.fromIpAddresses('1.2.3.4'),
      multiValueAnswer: true, // added
    });

Description of how you validated changes

I added unit test and integ test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 31, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 31, 2024 13:53
@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Jan 31, 2024
@badmintoncryer badmintoncryer changed the title feat(route53): multi value answer routing feat(route53): multivalue answer routing Jan 31, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions github-actions bot added the feature-request A feature should be added or improved. label Jan 31, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 31, 2024 14:12

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@badmintoncryer badmintoncryer marked this pull request as ready for review February 1, 2024 03:09
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Feb 1, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 1, 2024
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

Copy link
Contributor

mergify bot commented Feb 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 6, 2024
Copy link
Contributor

mergify bot commented Feb 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Contributor Author

@GavinZZ Thank you for your review!!
mergify job seems to be failed.

@GavinZZ
Copy link
Contributor

GavinZZ commented Feb 7, 2024

@mergify update

Copy link
Contributor

mergify bot commented Feb 7, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 66f71c6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0e6e37e into aws:main Feb 7, 2024
9 checks passed
TheRealAmazonKendra pushed a commit that referenced this pull request Feb 9, 2024
### Issue

Closes #28939.

### Reason for this change

When configuring multi-value answer routing, it was always necessary to set it via the L1 method or use an escape hatch.

### Description of changes

I added `multiValueAnswering` property to `RecordSetProps`.

```ts
    new route53.ARecord(this, 'MultiValueAnswerRouting', {
      zone: hostedZone,
      recordName: 'www',
      target: route53.RecordTarget.fromIpAddresses('1.2.3.4'),
      multiValueAnswer: true, // added
    });
```

### Description of how you validated changes

I added unit test and integ test.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

route53: support for multivalue answer routing
3 participants