Skip to content

Commit

Permalink
feat(route53): multivalue answer routing (#28938)
Browse files Browse the repository at this point in the history
### Issue

Closes #28939.

### Reason for this change

When configuring multi-value answer routing, it was always necessary to set it via the L1 method or use an escape hatch.

### Description of changes

I added `multiValueAnswering` property to `RecordSetProps`.

```ts
    new route53.ARecord(this, 'MultiValueAnswerRouting', {
      zone: hostedZone,
      recordName: 'www',
      target: route53.RecordTarget.fromIpAddresses('1.2.3.4'),
      multiValueAnswer: true, // added
    });
```

### Description of how you validated changes

I added unit test and integ test.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
badmintoncryer authored and TheRealAmazonKendra committed Feb 9, 2024
1 parent a9ff59b commit dec7de0
Show file tree
Hide file tree
Showing 12 changed files with 553 additions and 5 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
{
"Resources": {
"HostedZoneDB99F866": {
"Type": "AWS::Route53::HostedZone",
"Properties": {
"Name": "cdk.dev."
}
},
"MultiValueAnswerRoutingF3C1E535": {
"Type": "AWS::Route53::RecordSet",
"Properties": {
"HostedZoneId": {
"Ref": "HostedZoneDB99F866"
},
"MultiValueAnswer": true,
"Name": "www.cdk.dev.",
"ResourceRecords": [
"1.2.3.4"
],
"SetIdentifier": "MVA_ID_multivalueanswerroutingMultiValueAnswerRoutingD94947BD",
"TTL": "1800",
"Type": "A"
}
}
},
"Parameters": {
"BootstrapVersion": {
"Type": "AWS::SSM::Parameter::Value<String>",
"Default": "/cdk-bootstrap/hnb659fds/version",
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"
}
},
"Rules": {
"CheckBootstrapVersion": {
"Assertions": [
{
"Assert": {
"Fn::Not": [
{
"Fn::Contains": [
[
"1",
"2",
"3",
"4",
"5"
],
{
"Ref": "BootstrapVersion"
}
]
}
]
},
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."
}
]
}
}
}

0 comments on commit dec7de0

Please sign in to comment.